From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932131AbcGDGtQ (ORCPT ); Mon, 4 Jul 2016 02:49:16 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:36009 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752123AbcGDGtN (ORCPT ); Mon, 4 Jul 2016 02:49:13 -0400 MIME-Version: 1.0 In-Reply-To: <87zipyz1w9.wl%kuninori.morimoto.gx@renesas.com> References: <87lh1ykqs4.wl%kuninori.morimoto.gx@renesas.com> <201607031043.pubKFAon%fengguang.wu@intel.com> <87zipyz1w9.wl%kuninori.morimoto.gx@renesas.com> From: Geert Uytterhoeven Date: Mon, 4 Jul 2016 08:49:12 +0200 X-Google-Sender-Auth: j3giGw0fIg_WwhTKTEE4XqTNH8M Message-ID: Subject: Re: [PATCH] thermal: hwmon: EXPORT_SYMBOL for thermal hwmon sysfs To: Kuninori Morimoto Cc: Zhang Rui , "edubezval@gmail.com" , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "yoshihiro.shimoda.uh@renesas.com" , "cm-hiep@jinso.co.jp" , PhucBui Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Morimoto-san, On Mon, Jul 4, 2016 at 2:31 AM, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > thermal_add_hwmon_sysfs()/thermal_remove_hwmon_sysfs() need > EXPORT_SYMBOL(). Otherwise we will have ERROR > >>> ERROR: "thermal_remove_hwmon_sysfs" [drivers/thermal/rcar_thermal.ko] undefined! >>> ERROR: "thermal_add_hwmon_sysfs" [drivers/thermal/rcar_thermal.ko] undefined! > > Signed-off-by: Kuninori Morimoto > --- > drivers/thermal/thermal_hwmon.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c > index 06fd2ed9..8eecba8 100644 > --- a/drivers/thermal/thermal_hwmon.c > +++ b/drivers/thermal/thermal_hwmon.c > @@ -232,6 +232,7 @@ int thermal_add_hwmon_sysfs(struct thermal_zone_device *tz) > > return result; > } > +EXPORT_SYMBOL(thermal_add_hwmon_sysfs); EXPORT_SYMBOL_GPL? That seems to be prevalent in the thermal subsystem, except for a few cases in cpu_cooling.c and thermal_helpers.c. > void thermal_remove_hwmon_sysfs(struct thermal_zone_device *tz) > { > @@ -270,3 +271,4 @@ void thermal_remove_hwmon_sysfs(struct thermal_zone_device *tz) > hwmon_device_unregister(hwmon->device); > kfree(hwmon); > } > +EXPORT_SYMBOL(thermal_remove_hwmon_sysfs); EXPORT_SYMBOL_GPL? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds