From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Adam Ford <aford173@gmail.com>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Adam Ford-BE <aford@beaconembedded.com>,
Sergei Shtylyov <sergei.shtylyov@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
netdev <netdev@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] dt-bindings: net: renesas,etheravb: Add additional clocks
Date: Fri, 8 Jan 2021 15:24:03 +0100 [thread overview]
Message-ID: <CAMuHMdUbkYy5chXfvyzC6L0HzDRbyzAKx2gzTMcCz=N-rdLoAg@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdWE7FS-BLjT0sXupPX+V7XOTjN8ZKnRmShNEOx0i9DCGQ@mail.gmail.com>
Hi Adam,
On Fri, Jan 8, 2021 at 3:11 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Mon, Dec 28, 2020 at 10:32 PM Adam Ford <aford173@gmail.com> wrote:
> > The AVB driver assumes there is an external clock, but it could
> > be driven by an external clock. In order to enable a programmable
> > clock, it needs to be added to the clocks list and enabled in the
> > driver. Since there currently only one clock, there is no
> > clock-names list either.
> >
> > Update bindings to add the additional optional clock, and explicitly
> > name both of them.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Upon second look...
>> --- a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
>> +++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
>> @@ -49,7 +49,16 @@ properties:
>> interrupt-names: true
>>
>> clocks:
>> - maxItems: 1
>> + minItems: 1
>> + maxItems: 2
>> + items:
>> + - description: AVB functional clock
>> + - description: Optional TXC reference clock
>> +
>> + clock-names:
>> + items:
>> + - const: fck
>> + - const: txc_refclk
On R-Car Gen3 and RZ/G2, RGMII is used, and this clock is called
"txcrefclk", i.e. without underscore.
On R-Car Gen2, GMII is used, and this clock is called "gtxrefclk".
Perhaps it should just be called "refclk"?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-01-08 14:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 21:31 [PATCH 1/4] dt-bindings: net: renesas,etheravb: Add additional clocks Adam Ford
2020-12-28 21:31 ` [PATCH 2/4] ARM: dts: renesas: Add fck to etheravb-rcar-gen2 clock-names list Adam Ford
2020-12-29 8:36 ` Sergei Shtylyov
2021-01-08 14:15 ` Geert Uytterhoeven
2020-12-28 21:31 ` [PATCH 3/4] arm64: dts: renesas: Add fck to etheravb-rcar-gen3 " Adam Ford
2021-01-08 14:26 ` Geert Uytterhoeven
2020-12-28 21:31 ` [PATCH 4/4] net: ethernet: ravb: Name the AVB functional clock fck Adam Ford
2020-12-29 8:22 ` Sergei Shtylyov
2021-01-04 10:41 ` Geert Uytterhoeven
2021-01-05 12:53 ` Adam Ford
2021-01-08 14:13 ` Geert Uytterhoeven
2020-12-29 8:17 ` [PATCH 1/4] dt-bindings: net: renesas,etheravb: Add additional clocks Sergei Shtylyov
2021-01-08 14:11 ` Geert Uytterhoeven
2021-01-08 14:24 ` Geert Uytterhoeven [this message]
2021-01-11 20:19 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdUbkYy5chXfvyzC6L0HzDRbyzAKx2gzTMcCz=N-rdLoAg@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).