From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Trevor Wu <trevor.wu@mediatek.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-mediatek@lists.infradead.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: mediatek: SND_SOC_MT8195 should depend on ARCH_MEDIATEK
Date: Wed, 1 Sep 2021 09:14:50 +0200 [thread overview]
Message-ID: <CAMuHMdUd+j7MYv3LXOH1C45UjEqVVjwm1mmyzpZyv+cuR3cDaw@mail.gmail.com> (raw)
In-Reply-To: <535478691c3a9ed31b508f59dc897be57c4213c0.camel@mediatek.com>
Hi Trevor,
On Wed, Sep 1, 2021 at 5:48 AM Trevor Wu <trevor.wu@mediatek.com> wrote:
> On Tue, 2021-08-31 at 15:18 +0200, Geert Uytterhoeven wrote:
> > The Mediatek MT8195 sound hardware is only present on Mediatek MT8195
> > SoCs. Hence add a dependency on ARCH_MEDIATEK, to prevent asking the
> > user about this driver when configuring a kernel without Mediatek SoC
> > support.
> >
> > Fixes: 6746cc858259985a ("ASoC: mediatek: mt8195: add platform
> > driver")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > sound/soc/mediatek/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig
> > index cf567a89f421b4c0..c8c815f599da90bf 100644
> > --- a/sound/soc/mediatek/Kconfig
> > +++ b/sound/soc/mediatek/Kconfig
> > @@ -187,6 +187,7 @@ config SND_SOC_MT8192_MT6359_RT1015_RT5682
> >
> > config SND_SOC_MT8195
> > tristate "ASoC support for Mediatek MT8195 chip"
> > + depends on ARCH_MEDIATEK || COMPILE_TEST
> > select SND_SOC_MEDIATEK
> > help
> > This adds ASoC platform driver support for Mediatek MT8195
> > chip
>
> Hi Geert,
>
> Thanks for your patch first.
> I really missed the dependency declaration.
> But we only test "depends on ARCH_MEDIATEK" internally, maybe removing
> "COMPILE_TEST" like other MTK series is better for the maintenance in
> the future.
If the driver compiles with CONFIG_ARCH_MEDIATEK=n, it is better
to enable compile-testing, as that may catch issues.\
I didn't change the existing MTK symbols, only new symbols.
(adding missing dependencies to existing symbols is in my (huge) backlog ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-09-01 7:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 13:18 [PATCH] ASoC: mediatek: SND_SOC_MT8195 should depend on ARCH_MEDIATEK Geert Uytterhoeven
2021-09-01 3:48 ` Trevor Wu
2021-09-01 7:14 ` Geert Uytterhoeven [this message]
2021-09-01 18:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdUd+j7MYv3LXOH1C45UjEqVVjwm1mmyzpZyv+cuR3cDaw@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=trevor.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).