From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1593DC433F5 for ; Sat, 12 Feb 2022 15:55:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236737AbiBLPzF (ORCPT ); Sat, 12 Feb 2022 10:55:05 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:57722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233997AbiBLPzD (ORCPT ); Sat, 12 Feb 2022 10:55:03 -0500 Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5224B197; Sat, 12 Feb 2022 07:54:59 -0800 (PST) Received: by mail-ua1-f47.google.com with SMTP id g15so5951187uap.11; Sat, 12 Feb 2022 07:54:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m9MAkIW4ew1KSxPxGSDwKOj26B+ub0fwkAp4ZOf7U70=; b=iMwZN4VvmS9qaiov9WMpCFoM0Ve99EpEYJPKfkvekfGjNVAm5pCkgHLX9vkNksBtb1 i/YL3KFqHw3A5JcZm5AcDENsZsNLeV20dm1HxrbTD1VAGoKHYTm/+I3AhL0LuWQG0bhW NM31qpfAuyRtzk2sp2u7pbzp52he/ullYC2v6+j+nmLhO+6ousfJif7iCdUm7b1pWwS8 STuXGM6u3cBImIsDbjSdU+g0ltLtkcpjNXmA+ORlSC5RGN9a2LYj59H+aAbO3v730uaf +zb+mv52MK12Lgi1ur3kGh+okm0ZTMIUHaETYsf3qmOLvahYYetyOyutR/KtpSdt92D0 Pv/Q== X-Gm-Message-State: AOAM531L6R9bMvePdoxme0pxi/lZfY2eLpiViZx1RxM5HMqqsJ9509BU pJ/zb+qmPkceOCk/Ms+k5k7ZGFpb9TmDCA== X-Google-Smtp-Source: ABdhPJxK7duc+8awU+iwYIsNtApfes7mu3VnqVrH8O5oEYcdBi6WWa0agVkmPrWsN3gnzcdAqqXQVw== X-Received: by 2002:ab0:3053:: with SMTP id x19mr1909334ual.5.1644681298236; Sat, 12 Feb 2022 07:54:58 -0800 (PST) Received: from mail-ua1-f46.google.com (mail-ua1-f46.google.com. [209.85.222.46]) by smtp.gmail.com with ESMTPSA id n10sm4609148vso.34.2022.02.12.07.54.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 12 Feb 2022 07:54:57 -0800 (PST) Received: by mail-ua1-f46.google.com with SMTP id 60so5973392uae.1; Sat, 12 Feb 2022 07:54:57 -0800 (PST) X-Received: by 2002:ab0:384c:: with SMTP id h12mr1820269uaw.122.1644681296996; Sat, 12 Feb 2022 07:54:56 -0800 (PST) MIME-Version: 1.0 References: <20220211143358.3112958-1-javierm@redhat.com> <20220211143358.3112958-3-javierm@redhat.com> In-Reply-To: <20220211143358.3112958-3-javierm@redhat.com> From: Geert Uytterhoeven Date: Sat, 12 Feb 2022 16:54:45 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 2/6] drm/format-helper: Add drm_fb_xrgb8888_to_mono_reversed() To: Javier Martinez Canillas Cc: Linux Kernel Mailing List , Daniel Vetter , Linux Fbdev development list , Sam Ravnborg , Maxime Ripard , DRI Development , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , Thomas Zimmermann , Andy Shevchenko , Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Javier, On Fri, Feb 11, 2022 at 3:34 PM Javier Martinez Canillas wrote: > Add support to convert from XR24 to reversed monochrome for drivers that > control monochromatic display panels, that only have 1 bit per pixel. > > The function does a line-by-line conversion doing an intermediate step > first from XR24 to 8-bit grayscale and then to reversed monochrome. > > The drm_fb_gray8_to_mono_reversed_line() helper was based on code from > drivers/gpu/drm/tiny/repaper.c driver. > > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Thomas Zimmermann Thanks for your patch! > --- a/drivers/gpu/drm/drm_format_helper.c > +++ b/drivers/gpu/drm/drm_format_helper.c > @@ -12,9 +12,11 @@ > #include > #include > > +#include > #include > #include > #include > +#include > #include > > static unsigned int clip_offset(const struct drm_rect *clip, unsigned int pitch, unsigned int cpp) > @@ -591,3 +593,111 @@ int drm_fb_blit_toio(void __iomem *dst, unsigned int dst_pitch, uint32_t dst_for > return -EINVAL; > } > EXPORT_SYMBOL(drm_fb_blit_toio); > + > +static void drm_fb_gray8_to_mono_reversed_line(u8 *dst, const u8 *src, unsigned int pixels, > + unsigned int start_offset, unsigned int end_len) > +{ > + unsigned int xb, i; > + > + for (xb = 0; xb < pixels; xb++) { > + unsigned int start = 0, end = 8; > + u8 byte = 0x00; > + > + if (xb == 0 && start_offset) > + start = start_offset; > + > + if (xb == pixels - 1 && end_len) > + end = end_len; > + > + for (i = start; i < end; i++) { > + unsigned int x = xb * 8 + i; > + > + byte >>= 1; > + if (src[x] >> 7) > + byte |= BIT(7); > + } x = xb * 8; for (i = start; i < end; i++) { byte >>= 1; byte |= src[x + i] & BIT(7); } > + *dst++ = byte; > + } > +} > + > +/** > + * drm_fb_xrgb8888_to_mono_reversed - Convert XRGB8888 to reversed monochrome > + * @dst: reversed monochrome destination buffer > + * @dst_pitch: Number of bytes between two consecutive scanlines within dst > + * @src: XRGB8888 source buffer > + * @fb: DRM framebuffer > + * @clip: Clip rectangle area to copy > + * > + * DRM doesn't have native monochrome support. > + * Such drivers can announce the commonly supported XR24 format to userspace > + * and use this function to convert to the native format. > + * > + * This function uses drm_fb_xrgb8888_to_gray8() to convert to grayscale and > + * then the result is converted from grayscale to reversed monohrome. > + */ > +void drm_fb_xrgb8888_to_mono_reversed(void *dst, unsigned int dst_pitch, const void *vaddr, > + const struct drm_framebuffer *fb, const struct drm_rect *clip) > +{ > + unsigned int linepixels = drm_rect_width(clip); > + unsigned int lines = clip->y2 - clip->y1; > + unsigned int cpp = fb->format->cpp[0]; > + unsigned int len_src32 = linepixels * cpp; > + struct drm_device *dev = fb->dev; > + unsigned int start_offset, end_len; > + unsigned int y; > + u8 *mono = dst, *gray8; > + u32 *src32; > + > + if (drm_WARN_ON(dev, fb->format->format != DRM_FORMAT_XRGB8888)) > + return; > + > + /* > + * The reversed mono destination buffer contains 1 bit per pixel > + * and destination scanlines have to be in multiple of 8 pixels. > + */ > + if (!dst_pitch) > + dst_pitch = DIV_ROUND_UP(linepixels, 8); > + > + drm_WARN_ONCE(dev, dst_pitch % 8 != 0, "dst_pitch is not a multiple of 8\n"); > + > + /* > + * The cma memory is write-combined so reads are uncached. > + * Speed up by fetching one line at a time. > + * > + * Also, format conversion from XR24 to reversed monochrome > + * are done line-by-line but are converted to 8-bit grayscale > + * as an intermediate step. > + * > + * Allocate a buffer to be used for both copying from the cma > + * memory and to store the intermediate grayscale line pixels. > + */ > + src32 = kmalloc(len_src32 + linepixels, GFP_KERNEL); > + if (!src32) > + return; > + > + gray8 = (u8 *)src32 + len_src32; The cast can be removed if src32 is changed to "void *". For symmetry, gray8 and mono can be changed to "void *", too. > + > + /* > + * For damage handling, it is possible that only parts of the source > + * buffer is copied and this could lead to start and end pixels that > + * are not aligned to multiple of 8. > + * > + * Calculate if the start and end pixels are not aligned and set the > + * offsets for the reversed mono line conversion function to adjust. > + */ > + start_offset = clip->x1 % 8; > + end_len = clip->x2 % 8; > + > + vaddr += clip_offset(clip, fb->pitches[0], cpp); > + for (y = 0; y < lines; y++) { > + src32 = memcpy(src32, vaddr, len_src32); > + drm_fb_xrgb8888_to_gray8_line(gray8, src32, linepixels); > + drm_fb_gray8_to_mono_reversed_line(mono, gray8, dst_pitch, > + start_offset, end_len); > + vaddr += fb->pitches[0]; > + mono += dst_pitch; > + } > + > + kfree(src32); > +} > +EXPORT_SYMBOL(drm_fb_xrgb8888_to_mono_reversed); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds