linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: "Linux/m68k" <linux-m68k@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/10] mac68k: Miscellaneous fixes, cleanup and modernization
Date: Thu, 20 Apr 2017 09:56:16 +0200	[thread overview]
Message-ID: <CAMuHMdUfVR1PqXPRwT9GKk-T9wZiiAziT8bPyEemw5y5EiUh5A@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1704171150090.15400@nippy.intranet>

Hi Finn,

On Mon, Apr 17, 2017 at 3:50 AM, Finn Thain <fthain@telegraphics.com.au> wrote:
> On Sun, 16 Apr 2017, Geert Uytterhoeven wrote:
>> On Sun, Apr 9, 2017 at 1:51 AM, Finn Thain <fthain@telegraphics.com.au>
>> wrote:
>> > This series has various patches from several different people. Two
>> > printk modernization patches were originally from Geert Uytterhoeven
>> > and three Nubus patches were originally committed to the Linux/mac68k
>> > CVS by David Huggins-Daines.
>>
>> Thanks, most of them look sane enough to apply and still queue for
>> v4.12.
>>
>> I'm a bit reluctant about the nubus changes (patches 6 and 8), though.
>> Do you think they need more testing?
>>
>> Thanks!
>
> Patch 6 is partly dead code removal. In principle, this patch is a
> reversion to the old code (pre-v2.3.17). The old code was thoroughly
> tested in Debian Sarge. I suppose a reviewer might wonder whether we want
> to keep new code for probing fake slot resources in Apple's on-board ROMs.
> That would be useful if it could eliminate the macintosh_config struct.
> But it can't, and we don't want both mechanisms. Hence the reversion in
> the mac68k CVS.
>
> Patch 8 changes the pointer validation code and although this has been
> tested on the valid path, you are right that it could use some negative
> testing. But that would seem to require cards with flawed ROMs. I don't
> know of any of such cards. So I think that all we can do is more review.
>
> Maybe Michael or Laurent would be willing to review these two patches?

OK.

I've applied and queued all but patches 6 and 8.  This required some
small adjustment to e.g. the whitespace patch.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

      reply	other threads:[~2017-04-20  7:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-08 23:51 [PATCH 00/10] mac68k: Miscellaneous fixes, cleanup and modernization Finn Thain
2017-04-08 23:51 ` [PATCH 02/10] m68k/mac: Modernize printing of kernel messages Finn Thain
2017-04-08 23:51 ` [PATCH 07/10] nubus: Clean up printk calls (from mac68k CVS) Finn Thain
2017-04-08 23:51 ` [PATCH 01/10] m68k/mac: IOP - Modernize printing of kernel messages Finn Thain
2017-04-08 23:51 ` [PATCH 09/10] nubus: Clean up whitespace Finn Thain
2017-04-08 23:51 ` [PATCH 04/10] m68k/mac: Clarify IOP message alloc/free confusion Finn Thain
2017-04-08 23:51 ` [PATCH 10/10] nubus: Add MVC and VSC video card definitions Finn Thain
2017-04-08 23:51 ` [PATCH 03/10] m68k/mac: Adopt platform_device_register_simple() Finn Thain
2017-04-08 23:51 ` [PATCH 05/10] nubus: Fix nubus_rewinddir (from mac68k CVS) Finn Thain
2017-04-08 23:51 ` [PATCH 08/10] nubus: Fix pointer validation Finn Thain
2017-04-08 23:51 ` [PATCH 06/10] nubus: Remove slot zero probe (from mac68k CVS) Finn Thain
2017-04-16 10:29 ` [PATCH 00/10] mac68k: Miscellaneous fixes, cleanup and modernization Geert Uytterhoeven
2017-04-17  1:50   ` Finn Thain
2017-04-20  7:56     ` Geert Uytterhoeven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdUfVR1PqXPRwT9GKk-T9wZiiAziT8bPyEemw5y5EiUh5A@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=fthain@telegraphics.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).