From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Saravana Kannan <saravanak@google.com>
Cc: Russell King <linux@armlinux.org.uk>,
Neil Armstrong <narmstrong@baylibre.com>,
Magnus Damm <magnus.damm@gmail.com>,
Tony Lindgren <tony@atomide.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Damien Le Moal <damien.lemoal@wdc.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Android Kernel Team <kernel-team@android.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-oxnas@groups.io,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:TI ETHERNET SWITCH DRIVER (CPSW)"
<linux-omap@vger.kernel.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH v3 1/2] drivers: bus: simple-pm-bus: Add support for probing simple bus only devices
Date: Mon, 6 Sep 2021 09:53:49 +0200 [thread overview]
Message-ID: <CAMuHMdUhZy7W_HLtNJ2ECK5uQV5xHV7pDk5BXfNUpW9L68G5Aw@mail.gmail.com> (raw)
In-Reply-To: <20210904000543.2019010-2-saravanak@google.com>
Hi Saravana,
Thanks for your patch!
CC linux-pm, Lee (mfd)
On Sat, Sep 4, 2021 at 2:05 AM Saravana Kannan <saravanak@google.com> wrote:
> fw_devlink could end up creating device links for bus only devices.
> However, bus only devices don't get probed and can block probe() or
> sync_state() [1] call backs of other devices. To avoid this, probe these
> devices using the simple-pm-bus driver.
>
> However, there are instances of devices that are not simple buses (they
> get probed by their specific drivers) that also list the "simple-bus"
> (or other bus only compatible strings) in their compatible property to
> automatically populate their child devices. We still want these devices
> to get probed by their specific drivers. So, we make sure this driver
> only probes devices that are only buses.
Note that this can also be the case for buses declaring compatibility
with "simple-pm-bus". However, at the moment, none of such device
nodes in upstream DTS files have device-specific drivers.
> [1] - https://lore.kernel.org/lkml/CAPDyKFo9Bxremkb1dDrr4OcXSpE0keVze94Cm=zrkOVxHHxBmQ@mail.gmail.com/
> Signed-off-by: Saravana Kannan <saravanak@google.com>
> Tested-by: Saravana Kannan <saravanak@google.com>
> --- a/drivers/bus/simple-pm-bus.c
> +++ b/drivers/bus/simple-pm-bus.c
> @@ -13,11 +13,26 @@
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
>
> -
> static int simple_pm_bus_probe(struct platform_device *pdev)
> {
> - const struct of_dev_auxdata *lookup = dev_get_platdata(&pdev->dev);
> - struct device_node *np = pdev->dev.of_node;
> + const struct device *dev = &pdev->dev;
> + const struct of_dev_auxdata *lookup = dev_get_platdata(dev);
> + struct device_node *np = dev->of_node;
> + const struct of_device_id *match;
> +
> + match = of_match_device(dev->driver->of_match_table, dev);
> +
> + /*
> + * These are transparent bus devices (not simple-pm-bus matches) that
> + * have their child nodes populated automatically. So, don't need to
> + * do anything more.
> + */
> + if (match && match->data) {
> + if (of_property_match_string(np, "compatible", match->compatible) == 0)
Does this work as expected? Having multiple compatible values in a
device node does not guarantee there exist a separate driver for any
of the device-specific compatible values.
> + return 0;
> + else
> + return -ENODEV;
So if we get here, as both branches use "return", we skip the
pm_runtime_enable() and of_platform_populate() below:
- of_platform_populate() is handled for these buses by
of_platform_default_populate(), so that's OK,
- I'm wondering if any of the simple-mfd sub-devices use Runtime
PM, but currently fail to save power because pm_runtime_enable()
is never called for the MFD container, just like with simple-bus...
> + }
>
> dev_dbg(&pdev->dev, "%s\n", __func__);
>
> @@ -31,14 +46,25 @@ static int simple_pm_bus_probe(struct platform_device *pdev)
>
> static int simple_pm_bus_remove(struct platform_device *pdev)
> {
> + const void *data = of_device_get_match_data(&pdev->dev);
> +
> + if (data)
> + return 0;
> +
> dev_dbg(&pdev->dev, "%s\n", __func__);
>
> pm_runtime_disable(&pdev->dev);
> return 0;
> }
>
> +#define ONLY_BUS ((void *) 1) /* Match if the device is only a bus. */
> +
> static const struct of_device_id simple_pm_bus_of_match[] = {
> { .compatible = "simple-pm-bus", },
> + { .compatible = "simple-bus", .data = ONLY_BUS },
> + { .compatible = "simple-mfd", .data = ONLY_BUS },
> + { .compatible = "isa", .data = ONLY_BUS },
#ifdef CONFIG_ARM_AMBA ?
> + { .compatible = "arm,amba-bus", .data = ONLY_BUS },
> { /* sentinel */ }
This is now (almost[*]) the same as of_default_bus_match_table[]
in drivers/of/platform.c. Perhaps it can be shared?
[*] Especially if "simple-pm-bus" and "simple-bus" would be treated
the same.
> };
> MODULE_DEVICE_TABLE(of, simple_pm_bus_of_match);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-09-06 7:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 0:05 [PATCH v3 0/2] Fix simple-bus issues with fw_devlink Saravana Kannan
2021-09-04 0:05 ` [PATCH v3 1/2] drivers: bus: simple-pm-bus: Add support for probing simple bus only devices Saravana Kannan
2021-09-06 7:53 ` Geert Uytterhoeven [this message]
2021-09-07 7:01 ` Saravana Kannan
2021-09-09 0:15 ` Rob Herring
2021-09-09 0:57 ` Saravana Kannan
2021-09-09 14:01 ` Rob Herring
2021-09-09 18:11 ` Saravana Kannan
2021-09-10 15:21 ` Rob Herring
2021-09-07 10:41 ` Ulf Hansson
2021-09-08 22:02 ` Saravana Kannan
2021-09-09 11:01 ` Ulf Hansson
2021-09-24 11:49 ` Ulf Hansson
2021-09-24 20:20 ` Saravana Kannan
2021-09-04 0:05 ` [PATCH v3 2/2] drivers: bus: Delete CONFIG_SIMPLE_PM_BUS Saravana Kannan
2021-09-07 10:29 ` Ulf Hansson
2021-09-08 22:01 ` Saravana Kannan
2021-09-09 11:02 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdUhZy7W_HLtNJ2ECK5uQV5xHV7pDk5BXfNUpW9L68G5Aw@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=catalin.marinas@arm.com \
--cc=damien.lemoal@wdc.com \
--cc=kernel-team@android.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-oxnas@groups.io \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=saravanak@google.com \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).