From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Biju Das <biju.das.jz@bp.renesas.com>,
Prabhakar <prabhakar.csengg@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 12/12] arm64: dts: renesas: Add support for r9a07g044c1/r9a07g054l1-smarc.dts
Date: Fri, 21 Jan 2022 15:46:54 +0100 [thread overview]
Message-ID: <CAMuHMdUopcuP6XAd_Fw___04=-CyqJPEfNcwkrYgtdQz11yYvg@mail.gmail.com> (raw)
In-Reply-To: <20220110134659.30424-13-prabhakar.mahadev-lad.rj@bp.renesas.com>
Hi Prabhakar, Biju,
On Mon, Jan 10, 2022 at 2:47 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> From: Biju Das <biju.das.jz@bp.renesas.com>
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/Makefile
> +++ b/arch/arm64/boot/dts/renesas/Makefile
> @@ -77,4 +77,6 @@ dtb-$(CONFIG_ARCH_R8A77965) += r8a779m5-salvator-xs.dtb
>
> dtb-$(CONFIG_ARCH_R9A07G044) += r9a07g044l2-smarc.dtb
> dtb-$(CONFIG_ARCH_R9A07G044) += r9a07g044c2-smarc.dtb
> +dtb-$(CONFIG_ARCH_R9A07G044) += r9a07g044c1-smarc.dtb
Please preserve sort order, and add a blank line to separate
different SoCs.
> dtb-$(CONFIG_ARCH_R9A07G054) += r9a07g054l2-smarc.dtb
> +dtb-$(CONFIG_ARCH_R9A07G054) += r9a07g054l1-smarc.dtb
Sort order.
Given this patch adds boards with two different SoCs, and the two
DTS files are quite dissimilar, I think this patch should be split in
two parts.
> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/r9a07g044c1-smarc.dts
> @@ -0,0 +1,99 @@
> +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +/*
> + * Device Tree Source for the RZ/G2LC SMARC EVK board
> + *
> + * Copyright (C) 2021 Renesas Electronics Corp.
> + */
> +
> +/dts-v1/;
> +#include "r9a07g044c1.dtsi"
> +#include "rzg2lc-smarc-som.dtsi"
> +#include "rzg2lc-smarc-pinfunction.dtsi"
> +#include "rzg2l-smarc.dtsi"
> +
> +/ {
> + model = "Renesas SMARC EVK based on r9a07g044c2";
> + compatible = "renesas,smarc-evk", "renesas,r9a07g044c2", "renesas,r9a07g044";
"renesas,r9a07g044c1"
> +
> +};
> +
> +&canfd {
> + /delete-property/ pinctrl-0;
> + status = "disabled";
> +};
Looks like the corresponding pinctrl-names properties should be
removed, too. Else "make dtbs_check" complains.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2022-01-21 14:47 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 13:46 [PATCH v2 00/12] Add new Renesas RZ/V2L SoC and Renesas RZ/V2L SMARC EVK support Lad Prabhakar
2022-01-10 13:46 ` [PATCH v2 01/12] dt-bindings: power: renesas,rzg2l-sysc: Document RZ/V2L SoC Lad Prabhakar
2022-01-21 14:44 ` Geert Uytterhoeven
2022-01-10 13:46 ` [PATCH v2 02/12] soc: renesas: Identify " Lad Prabhakar
2022-01-21 14:44 ` Geert Uytterhoeven
2022-01-10 13:46 ` [PATCH v2 03/12] dt-bindings: clock: Add R9A07G054 CPG Clock and Reset Definitions Lad Prabhakar
2022-01-21 14:44 ` Geert Uytterhoeven
2022-01-21 16:20 ` Lad, Prabhakar
2022-01-10 13:46 ` [PATCH v2 04/12] dt-bindings: clock: renesas: Document RZ/V2L SoC Lad Prabhakar
2022-01-21 14:45 ` Geert Uytterhoeven
2022-01-10 13:46 ` [PATCH v2 05/12] clk: renesas: Add support for " Lad Prabhakar
2022-01-21 14:45 ` Geert Uytterhoeven
2022-01-21 16:31 ` Lad, Prabhakar
2022-01-21 16:39 ` Geert Uytterhoeven
2022-01-10 13:46 ` [PATCH v2 06/12] dt-bindings: pinctrl: renesas: Document RZ/V2L pinctrl Lad Prabhakar
2022-01-21 14:46 ` Geert Uytterhoeven
2022-01-10 13:46 ` [PATCH v2 07/12] pinctrl: renesas: Kconfig: Select PINCTRL_RZG2L if RZ/V2L SoC is enabled Lad Prabhakar
2022-01-21 14:46 ` Geert Uytterhoeven
2022-01-10 13:46 ` [PATCH v2 08/12] dt-bindings: dma: rz-dmac: Document RZ/V2L SoC Lad Prabhakar
2022-01-21 14:46 ` Geert Uytterhoeven
2022-02-15 5:01 ` Vinod Koul
2022-01-10 13:46 ` [PATCH v2 09/12] dt-bindings: net: renesas,etheravb: " Lad Prabhakar
2022-01-21 14:46 ` Geert Uytterhoeven
2022-01-10 13:46 ` [PATCH v2 10/12] arm64: dts: renesas: Add initial DTSI for " Lad Prabhakar
2022-01-21 14:46 ` Geert Uytterhoeven
2022-01-25 14:00 ` Rob Herring
2022-01-25 14:23 ` Geert Uytterhoeven
2022-01-10 13:46 ` [PATCH v2 11/12] arm64: dts: renesas: Add initial device tree for RZ/V2L SMARC EVK Lad Prabhakar
2022-01-21 14:46 ` Geert Uytterhoeven
2022-01-10 13:46 ` [PATCH v2 12/12] arm64: dts: renesas: Add support for r9a07g044c1/r9a07g054l1-smarc.dts Lad Prabhakar
2022-01-21 14:46 ` Geert Uytterhoeven [this message]
2022-01-21 16:38 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdUopcuP6XAd_Fw___04=-CyqJPEfNcwkrYgtdQz11yYvg@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).