Re: [PATCH] of: Provide dummy of_device_compatible_match() for compile-testing

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Rob Herring <robh+dt@kernel.org>, Frank Rowand <frowand.list@gmail.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] of: Provide dummy of_device_compatible_match() for compile-testing
Date: Tue, 13 Jun 2017 12:32:22 +0200	[thread overview]
Message-ID: <CAMuHMdUwXXioxt8_nhDM0x1h=KBb6HnNgkzwdM-qGVy7cSNH9Q@mail.gmail.com> (raw)
In-Reply-To: <1493141928-29251-1-git-send-email-geert+renesas@glider.be>

On Tue, Apr 25, 2017 at 7:38 PM, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> Most of_device_*() functions have dummy versions for CONFIG_OF=n,
> but of_device_compatible_match() hasn't.  Fix that to improve the
> ability to do compile-testing.
>
> Fixes: b9c13fe32faaa71c ("dt: Add of_device_compatible_match()")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Any reason not to apply this patch?

Thanks!

> ---
>  include/linux/of.h | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/include/linux/of.h b/include/linux/of.h
> index 21e6323de0f3b786..bfd1a23221735161 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -620,6 +620,12 @@ static inline int of_device_is_compatible(const struct device_node *device,
>         return 0;
>  }
>
> +static inline  int of_device_compatible_match(struct device_node *device,
> +                                             const char *const *compat)
> +{
> +       return 0;
> +}
> +
>  static inline bool of_device_is_available(const struct device_node *device)
>  {
>         return false;
> --
> 2.7.4