[PATCH 0/5 v3] sh: fixes for various build and kconfig warnings

[PATCH 0/5 v3] sh: fixes for various build and kconfig warnings

[Randy Dunlap]

Fix a few build warnings and one kconfig warning on SUPERH.

v3: add some Tested-by: and Reviewed-by:
    add 2 more patches
    renumber, rebase, and resend

v2: add a previously-sent Kconfig patch
    add a few more Cc's

 [PATCH 1/5 v3] sh: fix kconfig unmet dependency warning for FRAME_POINTER
 [PATCH 2/5 v3] sh: add git tree to MAINTAINERS
 [PATCH 3/5 v3] sh: math-emu: drop unused functions
 [PATCH 4/5 v3] sh: define __BIG_ENDIAN for math-emu
 [PATCH 5/5 v3] sh: fix READ/WRITE redefinition warnings

 MAINTAINERS                       |    1 
 arch/sh/Kconfig.debug             |    1 
 arch/sh/include/asm/sfp-machine.h |    8 +
 arch/sh/math-emu/math.c           |  147 ++++------------------------
 4 files changed, 32 insertions(+), 125 deletions(-)

Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
Cc: linux-sh@vger.kernel.org
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>

[PATCH 1/5 v3] sh: fix kconfig unmet dependency warning for FRAME_POINTER

[Randy Dunlap]

FRAME_POINTER depends on DEBUG_KERNEL so DWARF_UNWINDER should
depend on DEBUG_KERNEL before selecting FRAME_POINTER.

WARNING: unmet direct dependencies detected for FRAME_POINTER
  Depends on [n]: DEBUG_KERNEL [=n] && (M68K || UML || SUPERH [=y]) || ARCH_WANT_FRAME_POINTERS [=n]
  Selected by [y]:
  - DWARF_UNWINDER [=y]

Fixes: bd353861c735 ("sh: dwarf unwinder support.")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Matt Fleming <matt@console-pimps.org>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
Cc: linux-sh@vger.kernel.org
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
---
v2: drop Paul Mundt from Cc: list;
    add this previously sent patch to the series;
    add more Cc's;
v3: renumber, rebase, and resend;
    add Rev-by and Tested-by;

 arch/sh/Kconfig.debug |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20211001.orig/arch/sh/Kconfig.debug
+++ linux-next-20211001/arch/sh/Kconfig.debug
@@ -54,6 +54,7 @@ config DUMP_CODE
 
 config DWARF_UNWINDER
 	bool "Enable the DWARF unwinder for stacktraces"
+	depends on DEBUG_KERNEL
 	select FRAME_POINTER
 	default n
 	help

[PATCH 2/5 v3] sh: add git tree to MAINTAINERS

[Randy Dunlap]

Add the git tree location for linux-sh.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
Cc: linux-sh@vger.kernel.org
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
---
v3: new patch in this series

 MAINTAINERS |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20211001.orig/MAINTAINERS
+++ linux-next-20211001/MAINTAINERS
@@ -18047,6 +18047,7 @@ M:	Yoshinori Sato <ysato@users.sourcefor
 M:	Rich Felker <dalias@libc.org>
 L:	linux-sh@vger.kernel.org
 S:	Maintained
+T:	git git://git.libc.org/linux-sh
 Q:	http://patchwork.kernel.org/project/linux-sh/list/
 F:	Documentation/sh/
 F:	arch/sh/

[PATCH 3/5 v3] sh: math-emu: drop unused functions

[Randy Dunlap]

Delete ieee_fpe_handler() since it is not used. After that is done,
delete denormal_to_double() since it is not used:

../arch/sh/math-emu/math.c:505:12: error: 'ieee_fpe_handler' defined but not used [-Werror=unused-function]
  505 | static int ieee_fpe_handler(struct pt_regs *regs)

../arch/sh/math-emu/math.c:477:13: error: 'denormal_to_double' defined but not used [-Werror=unused-function]
  477 | static void denormal_to_double(struct sh_fpu_soft_struct *fpu, int n)

Fixes: 4b565680d163 ("sh: math-emu support")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Takashi YOSHII <takasi-y@ops.dti.ne.jp>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
Cc: linux-sh@vger.kernel.org
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
---
v3: new patch in this series;

 arch/sh/math-emu/math.c |  103 --------------------------------------
 1 file changed, 103 deletions(-)

--- linux-next-20211001.orig/arch/sh/math-emu/math.c
+++ linux-next-20211001/arch/sh/math-emu/math.c
@@ -468,109 +468,6 @@ static int fpu_emulate(u16 code, struct
 }
 
 /**
- *	denormal_to_double - Given denormalized float number,
- *	                     store double float
- *
- *	@fpu: Pointer to sh_fpu_soft structure
- *	@n: Index to FP register
- */
-static void denormal_to_double(struct sh_fpu_soft_struct *fpu, int n)
-{
-	unsigned long du, dl;
-	unsigned long x = fpu->fpul;
-	int exp = 1023 - 126;
-
-	if (x != 0 && (x & 0x7f800000) == 0) {
-		du = (x & 0x80000000);
-		while ((x & 0x00800000) == 0) {
-			x <<= 1;
-			exp--;
-		}
-		x &= 0x007fffff;
-		du |= (exp << 20) | (x >> 3);
-		dl = x << 29;
-
-		fpu->fp_regs[n] = du;
-		fpu->fp_regs[n+1] = dl;
-	}
-}
-
-/**
- *	ieee_fpe_handler - Handle denormalized number exception
- *
- *	@regs: Pointer to register structure
- *
- *	Returns 1 when it's handled (should not cause exception).
- */
-static int ieee_fpe_handler(struct pt_regs *regs)
-{
-	unsigned short insn = *(unsigned short *)regs->pc;
-	unsigned short finsn;
-	unsigned long nextpc;
-	int nib[4] = {
-		(insn >> 12) & 0xf,
-		(insn >> 8) & 0xf,
-		(insn >> 4) & 0xf,
-		insn & 0xf};
-
-	if (nib[0] == 0xb ||
-	    (nib[0] == 0x4 && nib[2] == 0x0 && nib[3] == 0xb)) /* bsr & jsr */
-		regs->pr = regs->pc + 4;
-
-	if (nib[0] == 0xa || nib[0] == 0xb) { /* bra & bsr */
-		nextpc = regs->pc + 4 + ((short) ((insn & 0xfff) << 4) >> 3);
-		finsn = *(unsigned short *) (regs->pc + 2);
-	} else if (nib[0] == 0x8 && nib[1] == 0xd) { /* bt/s */
-		if (regs->sr & 1)
-			nextpc = regs->pc + 4 + ((char) (insn & 0xff) << 1);
-		else
-			nextpc = regs->pc + 4;
-		finsn = *(unsigned short *) (regs->pc + 2);
-	} else if (nib[0] == 0x8 && nib[1] == 0xf) { /* bf/s */
-		if (regs->sr & 1)
-			nextpc = regs->pc + 4;
-		else
-			nextpc = regs->pc + 4 + ((char) (insn & 0xff) << 1);
-		finsn = *(unsigned short *) (regs->pc + 2);
-	} else if (nib[0] == 0x4 && nib[3] == 0xb &&
-		 (nib[2] == 0x0 || nib[2] == 0x2)) { /* jmp & jsr */
-		nextpc = regs->regs[nib[1]];
-		finsn = *(unsigned short *) (regs->pc + 2);
-	} else if (nib[0] == 0x0 && nib[3] == 0x3 &&
-		 (nib[2] == 0x0 || nib[2] == 0x2)) { /* braf & bsrf */
-		nextpc = regs->pc + 4 + regs->regs[nib[1]];
-		finsn = *(unsigned short *) (regs->pc + 2);
-	} else if (insn == 0x000b) { /* rts */
-		nextpc = regs->pr;
-		finsn = *(unsigned short *) (regs->pc + 2);
-	} else {
-		nextpc = regs->pc + 2;
-		finsn = insn;
-	}
-
-	if ((finsn & 0xf1ff) == 0xf0ad) { /* fcnvsd */
-		struct task_struct *tsk = current;
-
-		if ((tsk->thread.xstate->softfpu.fpscr & (1 << 17))) {
-			/* FPU error */
-			denormal_to_double (&tsk->thread.xstate->softfpu,
-					    (finsn >> 8) & 0xf);
-			tsk->thread.xstate->softfpu.fpscr &=
-				~(FPSCR_CAUSE_MASK | FPSCR_FLAG_MASK);
-			task_thread_info(tsk)->status |= TS_USEDFPU;
-		} else {
-			force_sig_fault(SIGFPE, FPE_FLTINV,
-					(void __user *)regs->pc);
-		}
-
-		regs->pc = nextpc;
-		return 1;
-	}
-
-	return 0;
-}
-
-/**
  * fpu_init - Initialize FPU registers
  * @fpu: Pointer to software emulated FPU registers.
  */

[PATCH 4/5 v3] sh: define __BIG_ENDIAN for math-emu

[Randy Dunlap]

Fix this by defining both ENDIAN macros in
<asm/sfp-machine.h> so that they can be utilized in
<math-emu/soft-fp.h> according to the latter's comment:
/* Allow sfp-machine to have its own byte order definitions. */

(This is what is done in arch/nds32/include/asm/sfp-machine.h.)

This placates these build warnings:

In file included from ../arch/sh/math-emu/math.c:23:
../include/math-emu/single.h:50:21: warning: "__BIG_ENDIAN" is not defined, evaluates to 0 [-Wundef]
   50 | #if __BYTE_ORDER == __BIG_ENDIAN
In file included from ../arch/sh/math-emu/math.c:24:
../include/math-emu/double.h:59:21: warning: "__BIG_ENDIAN" is not defined, evaluates to 0 [-Wundef]
   59 | #if __BYTE_ORDER == __BIG_ENDIAN

Fixes: 4b565680d163 ("sh: math-emu support")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
Cc: linux-sh@vger.kernel.org
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
---
v2: use same preprocessor method that nds32 does;
    add Geert's Reviewed-by;
    renumber patches;
    add more Cc's;
v3: renumber, rebase, and resend;
    add Tested-by: JPAG;

 arch/sh/include/asm/sfp-machine.h |    8 ++++++++
 1 file changed, 8 insertions(+)

--- linux-next-20211001.orig/arch/sh/include/asm/sfp-machine.h
+++ linux-next-20211001/arch/sh/include/asm/sfp-machine.h
@@ -13,6 +13,14 @@
 #ifndef _SFP_MACHINE_H
 #define _SFP_MACHINE_H
 
+#ifdef __BIG_ENDIAN__
+#define __BYTE_ORDER __BIG_ENDIAN
+#define __LITTLE_ENDIAN 0
+#else
+#define __BYTE_ORDER __LITTLE_ENDIAN
+#define __BIG_ENDIAN 0
+#endif
+
 #define _FP_W_TYPE_SIZE		32
 #define _FP_W_TYPE		unsigned long
 #define _FP_WS_TYPE		signed long

[PATCH 5/5 v3] sh: fix READ/WRITE redefinition warnings

[Randy Dunlap]

kernel.h defines READ and WRITE, so rename the SH math-emu macros
to MREAD and MWRITE.

Fixes these warnings:

../arch/sh/math-emu/math.c:54: warning: "WRITE" redefined
   54 | #define WRITE(d,a) ({if(put_user(d, (typeof (d) __user *)a)) return -EFAULT;})
In file included from ../arch/sh/math-emu/math.c:10:
../include/linux/kernel.h:37: note: this is the location of the previous definition
   37 | #define WRITE   1
../arch/sh/math-emu/math.c:55: warning: "READ" redefined
   55 | #define READ(d,a) ({if(get_user(d, (typeof (d) __user *)a)) return -EFAULT;})
In file included from ../arch/sh/math-emu/math.c:10:
../include/linux/kernel.h:36: note: this is the location of the previous definition
   36 | #define READ   0

Fixes: 4b565680d163 ("sh: math-emu support")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
Cc: linux-sh@vger.kernel.org
Cc: Takashi YOSHII <takasi-y@ops.dti.ne.jp>
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2: renumber patches, otherwise no change;
v3: renumber, rebase, & resend;
    add Rev-by: Geert;

 arch/sh/math-emu/math.c |   44 +++++++++++++++++++-------------------
 1 file changed, 22 insertions(+), 22 deletions(-)

--- linux-next-20211001.orig/arch/sh/math-emu/math.c
+++ linux-next-20211001/arch/sh/math-emu/math.c
@@ -51,8 +51,8 @@
 #define Rn	(regs->regs[n])
 #define Rm	(regs->regs[m])
 
-#define WRITE(d,a)	({if(put_user(d, (typeof (d) __user *)a)) return -EFAULT;})
-#define READ(d,a)	({if(get_user(d, (typeof (d) __user *)a)) return -EFAULT;})
+#define MWRITE(d,a)	({if(put_user(d, (typeof (d) __user *)a)) return -EFAULT;})
+#define MREAD(d,a)	({if(get_user(d, (typeof (d) __user *)a)) return -EFAULT;})
 
 #define PACK_S(r,f)	FP_PACK_SP(&r,f)
 #define UNPACK_S(f,r)	FP_UNPACK_SP(f,&r)
@@ -157,11 +157,11 @@ fmov_idx_reg(struct sh_fpu_soft_struct *
 {
 	if (FPSCR_SZ) {
 		FMOV_EXT(n);
-		READ(FRn, Rm + R0 + 4);
+		MREAD(FRn, Rm + R0 + 4);
 		n++;
-		READ(FRn, Rm + R0);
+		MREAD(FRn, Rm + R0);
 	} else {
-		READ(FRn, Rm + R0);
+		MREAD(FRn, Rm + R0);
 	}
 
 	return 0;
@@ -173,11 +173,11 @@ fmov_mem_reg(struct sh_fpu_soft_struct *
 {
 	if (FPSCR_SZ) {
 		FMOV_EXT(n);
-		READ(FRn, Rm + 4);
+		MREAD(FRn, Rm + 4);
 		n++;
-		READ(FRn, Rm);
+		MREAD(FRn, Rm);
 	} else {
-		READ(FRn, Rm);
+		MREAD(FRn, Rm);
 	}
 
 	return 0;
@@ -189,12 +189,12 @@ fmov_inc_reg(struct sh_fpu_soft_struct *
 {
 	if (FPSCR_SZ) {
 		FMOV_EXT(n);
-		READ(FRn, Rm + 4);
+		MREAD(FRn, Rm + 4);
 		n++;
-		READ(FRn, Rm);
+		MREAD(FRn, Rm);
 		Rm += 8;
 	} else {
-		READ(FRn, Rm);
+		MREAD(FRn, Rm);
 		Rm += 4;
 	}
 
@@ -207,11 +207,11 @@ fmov_reg_idx(struct sh_fpu_soft_struct *
 {
 	if (FPSCR_SZ) {
 		FMOV_EXT(m);
-		WRITE(FRm, Rn + R0 + 4);
+		MWRITE(FRm, Rn + R0 + 4);
 		m++;
-		WRITE(FRm, Rn + R0);
+		MWRITE(FRm, Rn + R0);
 	} else {
-		WRITE(FRm, Rn + R0);
+		MWRITE(FRm, Rn + R0);
 	}
 
 	return 0;
@@ -223,11 +223,11 @@ fmov_reg_mem(struct sh_fpu_soft_struct *
 {
 	if (FPSCR_SZ) {
 		FMOV_EXT(m);
-		WRITE(FRm, Rn + 4);
+		MWRITE(FRm, Rn + 4);
 		m++;
-		WRITE(FRm, Rn);
+		MWRITE(FRm, Rn);
 	} else {
-		WRITE(FRm, Rn);
+		MWRITE(FRm, Rn);
 	}
 
 	return 0;
@@ -240,12 +240,12 @@ fmov_reg_dec(struct sh_fpu_soft_struct *
 	if (FPSCR_SZ) {
 		FMOV_EXT(m);
 		Rn -= 8;
-		WRITE(FRm, Rn + 4);
+		MWRITE(FRm, Rn + 4);
 		m++;
-		WRITE(FRm, Rn);
+		MWRITE(FRm, Rn);
 	} else {
 		Rn -= 4;
-		WRITE(FRm, Rn);
+		MWRITE(FRm, Rn);
 	}
 
 	return 0;
@@ -445,11 +445,11 @@ id_sys(struct sh_fpu_soft_struct *fregs,
 	case 0x4052:
 	case 0x4062:
 		Rn -= 4;
-		WRITE(*reg, Rn);
+		MWRITE(*reg, Rn);
 		break;
 	case 0x4056:
 	case 0x4066:
-		READ(*reg, Rn);
+		MREAD(*reg, Rn);
 		Rn += 4;
 		break;
 	default:

Re: [PATCH 2/5 v3] sh: add git tree to MAINTAINERS

[Geert Uytterhoeven]

On Tue, Oct 5, 2021 at 2:19 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> Add the git tree location for linux-sh.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 3/5 v3] sh: math-emu: drop unused functions

[Geert Uytterhoeven]

Hi Randy,

Thanks for your patch!

On Tue, Oct 5, 2021 at 2:19 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> Delete ieee_fpe_handler() since it is not used. After that is done,
> delete denormal_to_double() since it is not used:
>
> ../arch/sh/math-emu/math.c:505:12: error: 'ieee_fpe_handler' defined but not used [-Werror=unused-function]
>   505 | static int ieee_fpe_handler(struct pt_regs *regs)
>
> ../arch/sh/math-emu/math.c:477:13: error: 'denormal_to_double' defined but not used [-Werror=unused-function]
>   477 | static void denormal_to_double(struct sh_fpu_soft_struct *fpu, int n)
>
> Fixes: 4b565680d163 ("sh: math-emu support")

Shouldn't that be
Fixes: 7caf62de25554da3 ("sh: remove unused do_fpu_error")
?

> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 3/5 v3] sh: math-emu: drop unused functions

[Randy Dunlap]

On 10/5/21 12:26 AM, Geert Uytterhoeven wrote:
> Hi Randy,
> 
> Thanks for your patch!
> 
> On Tue, Oct 5, 2021 at 2:19 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>> Delete ieee_fpe_handler() since it is not used. After that is done,
>> delete denormal_to_double() since it is not used:
>>
>> ../arch/sh/math-emu/math.c:505:12: error: 'ieee_fpe_handler' defined but not used [-Werror=unused-function]
>>    505 | static int ieee_fpe_handler(struct pt_regs *regs)
>>
>> ../arch/sh/math-emu/math.c:477:13: error: 'denormal_to_double' defined but not used [-Werror=unused-function]
>>    477 | static void denormal_to_double(struct sh_fpu_soft_struct *fpu, int n)
>>
>> Fixes: 4b565680d163 ("sh: math-emu support")
> 
> Shouldn't that be
> Fixes: 7caf62de25554da3 ("sh: remove unused do_fpu_error")
> ?

oh, ah, um. Yes, it should. Thanks!

> 
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Gr{oetje,eeting}s,
> 
>                          Geert
> 


-- 
~Randy

Re: [PATCH 5/5 v3] sh: fix READ/WRITE redefinition warnings

[Rob Landley]

On 10/4/21 7:19 PM, Randy Dunlap wrote:
> kernel.h defines READ and WRITE, so rename the SH math-emu macros
> to MREAD and MWRITE.

This one doesn't apply for me. My file has:

#define WRITE(d,a)      ({if(put_user(d, (typeof (d)*)a)) return -EFAULT;})

But your patch tries to remove:

-#define WRITE(d,a)     ({if(put_user(d, (typeof (d) __user *)a)) return -EFAULT;})

Which is odd because git log says my tree is current as of today, but git log on
this file says it was last updated:

commit 2e1661d2673667d886cd40ad9f414cb6db48d8da
Author: Eric W. Biederman <ebiederm@xmission.com>
Date:   Thu May 23 11:04:24 2019 -0500

What did I miss?

Rob

Re: [PATCH 5/5 v3] sh: fix READ/WRITE redefinition warnings

[Randy Dunlap]

On 10/8/21 11:39 AM, Rob Landley wrote:
> On 10/4/21 7:19 PM, Randy Dunlap wrote:
>> kernel.h defines READ and WRITE, so rename the SH math-emu macros
>> to MREAD and MWRITE.
> 
> This one doesn't apply for me. My file has:
> 
> #define WRITE(d,a)      ({if(put_user(d, (typeof (d)*)a)) return -EFAULT;})
> 
> But your patch tries to remove:
> 
> -#define WRITE(d,a)     ({if(put_user(d, (typeof (d) __user *)a)) return -EFAULT;})
> 
> Which is odd because git log says my tree is current as of today, but git log on
> this file says it was last updated:
> 
> commit 2e1661d2673667d886cd40ad9f414cb6db48d8da
> Author: Eric W. Biederman <ebiederm@xmission.com>
> Date:   Thu May 23 11:04:24 2019 -0500
> 
> What did I miss?

Hi Rob,

I am making patches to linux-next, which contains this:

commit ca42bc4b7bda
Author: Al Viro <viro@zeniv.linux.org.uk>
Date:   Thu Dec 31 23:23:01 2020 +0000

     sh: fix trivial misannotations

which adds the __user annotations...


-- 
~Randy

Re: [PATCH 2/5 v3] sh: add git tree to MAINTAINERS

[Rich Felker]

On Mon, Oct 04, 2021 at 05:19:11PM -0700, Randy Dunlap wrote:
> Add the git tree location for linux-sh.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Cc: Rich Felker <dalias@libc.org>
> Cc: linux-sh@vger.kernel.org
> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v3: new patch in this series
> 
>  MAINTAINERS |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20211001.orig/MAINTAINERS
> +++ linux-next-20211001/MAINTAINERS
> @@ -18047,6 +18047,7 @@ M:	Yoshinori Sato <ysato@users.sourcefor
>  M:	Rich Felker <dalias@libc.org>
>  L:	linux-sh@vger.kernel.org
>  S:	Maintained
> +T:	git git://git.libc.org/linux-sh
>  Q:	http://patchwork.kernel.org/project/linux-sh/list/
>  F:	Documentation/sh/
>  F:	arch/sh/

I'm omitting this for now since (as noted on the cgit description)
this server is not provisioned adequately for cloning from scratch,
and should only be used for fetch into an already-populated mainline
repo clone. If that's a problem I can see about getting it moved
somewhere more appropriate.

The rest of this series should appear in next shortly.

Rich

Re: [PATCH 2/5 v3] sh: add git tree to MAINTAINERS

[Geert Uytterhoeven]

Hi Rich,

On Wed, Oct 27, 2021 at 10:54 PM Rich Felker <dalias@libc.org> wrote:
> On Mon, Oct 04, 2021 at 05:19:11PM -0700, Randy Dunlap wrote:
> > Add the git tree location for linux-sh.
> >
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

> > --- linux-next-20211001.orig/MAINTAINERS
> > +++ linux-next-20211001/MAINTAINERS
> > @@ -18047,6 +18047,7 @@ M:    Yoshinori Sato <ysato@users.sourcefor
> >  M:   Rich Felker <dalias@libc.org>
> >  L:   linux-sh@vger.kernel.org
> >  S:   Maintained
> > +T:   git git://git.libc.org/linux-sh
> >  Q:   http://patchwork.kernel.org/project/linux-sh/list/
> >  F:   Documentation/sh/
> >  F:   arch/sh/
>
> I'm omitting this for now since (as noted on the cgit description)
> this server is not provisioned adequately for cloning from scratch,
> and should only be used for fetch into an already-populated mainline
> repo clone. If that's a problem I can see about getting it moved
> somewhere more appropriate.

Perhaps you can move it to kernel.org?

> The rest of this series should appear in next shortly.

Thanks a lot!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 2/5 v3] sh: add git tree to MAINTAINERS

[Rich Felker]

On Thu, Oct 28, 2021 at 10:33:54AM +0200, Geert Uytterhoeven wrote:
> Hi Rich,
> 
> On Wed, Oct 27, 2021 at 10:54 PM Rich Felker <dalias@libc.org> wrote:
> > On Mon, Oct 04, 2021 at 05:19:11PM -0700, Randy Dunlap wrote:
> > > Add the git tree location for linux-sh.
> > >
> > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> 
> > > --- linux-next-20211001.orig/MAINTAINERS
> > > +++ linux-next-20211001/MAINTAINERS
> > > @@ -18047,6 +18047,7 @@ M:    Yoshinori Sato <ysato@users.sourcefor
> > >  M:   Rich Felker <dalias@libc.org>
> > >  L:   linux-sh@vger.kernel.org
> > >  S:   Maintained
> > > +T:   git git://git.libc.org/linux-sh
> > >  Q:   http://patchwork.kernel.org/project/linux-sh/list/
> > >  F:   Documentation/sh/
> > >  F:   arch/sh/
> >
> > I'm omitting this for now since (as noted on the cgit description)
> > this server is not provisioned adequately for cloning from scratch,
> > and should only be used for fetch into an already-populated mainline
> > repo clone. If that's a problem I can see about getting it moved
> > somewhere more appropriate.
> 
> Perhaps you can move it to kernel.org?

I would love to. This was my hope years ago, but I got bogged down in
the GPG key signing requirements and folks not following through with
signing my key. Has any of that been streamlined since?

> > The rest of this series should appear in next shortly.
> 
> Thanks a lot!

Looks like it's been pulled by next now with no reports of anything
going wrong. I know it's late in the release cycle but should I
probably go ahead and send a PR?

Rich

Re: [PATCH 2/5 v3] sh: add git tree to MAINTAINERS

[Geert Uytterhoeven]

Hi Rich,

CC Konstantin

On Thu, Oct 28, 2021 at 3:30 PM Rich Felker <dalias@libc.org> wrote:
> On Thu, Oct 28, 2021 at 10:33:54AM +0200, Geert Uytterhoeven wrote:
> > On Wed, Oct 27, 2021 at 10:54 PM Rich Felker <dalias@libc.org> wrote:
> > > On Mon, Oct 04, 2021 at 05:19:11PM -0700, Randy Dunlap wrote:
> > > > Add the git tree location for linux-sh.
> > > >
> > > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> >
> > > > --- linux-next-20211001.orig/MAINTAINERS
> > > > +++ linux-next-20211001/MAINTAINERS
> > > > @@ -18047,6 +18047,7 @@ M:    Yoshinori Sato <ysato@users.sourcefor
> > > >  M:   Rich Felker <dalias@libc.org>
> > > >  L:   linux-sh@vger.kernel.org
> > > >  S:   Maintained
> > > > +T:   git git://git.libc.org/linux-sh
> > > >  Q:   http://patchwork.kernel.org/project/linux-sh/list/
> > > >  F:   Documentation/sh/
> > > >  F:   arch/sh/
> > >
> > > I'm omitting this for now since (as noted on the cgit description)
> > > this server is not provisioned adequately for cloning from scratch,
> > > and should only be used for fetch into an already-populated mainline
> > > repo clone. If that's a problem I can see about getting it moved
> > > somewhere more appropriate.
> >
> > Perhaps you can move it to kernel.org?
>
> I would love to. This was my hope years ago, but I got bogged down in
> the GPG key signing requirements and folks not following through with
> signing my key. Has any of that been streamlined since?

I'll let Konstantin respond...

> > > The rest of this series should appear in next shortly.
> >
> > Thanks a lot!
>
> Looks like it's been pulled by next now with no reports of anything
> going wrong. I know it's late in the release cycle but should I

Good!

> probably go ahead and send a PR?

Actually you're right on time ;-)
Your tree is based on v5.15-rc1, and the merge window for v5.16 is
expected to open on Monday. So you can send the PR right away.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 2/5 v3] sh: add git tree to MAINTAINERS

[Konstantin Ryabitsev]

On Thu, Oct 28, 2021 at 03:37:47PM +0200, Geert Uytterhoeven wrote:
> > > > I'm omitting this for now since (as noted on the cgit description)
> > > > this server is not provisioned adequately for cloning from scratch,
> > > > and should only be used for fetch into an already-populated mainline
> > > > repo clone. If that's a problem I can see about getting it moved
> > > > somewhere more appropriate.
> > >
> > > Perhaps you can move it to kernel.org?
> >
> > I would love to. This was my hope years ago, but I got bogged down in
> > the GPG key signing requirements and folks not following through with
> > signing my key. Has any of that been streamlined since?
> 
> I'll let Konstantin respond...

We still require a valid web of trust before we can issue an account, so
things haven't really changed in that regard. You have to get a PGP signature
from at least 2 other people who already have an account on kernel.org.

If you just need to host your git tree for hosting and sending pull requests,
then there's really no lack of options. Any large commercial git forge will
do just fine, including github, gitlab, gitea, sourcehut, etc. There's nothing
really special about kernel.org in this regard.

-K