From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Adam Ford <aford173@gmail.com>
Cc: ALSA Development Mailing List <alsa-devel@alsa-project.org>,
Adam Ford-BE <aford@beaconembedded.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: wm8962: Add optional mclk device tree binding
Date: Fri, 18 Dec 2020 13:58:48 +0100 [thread overview]
Message-ID: <CAMuHMdV3WKFLPKf_6nVc0bX4wXe55GtKST9whiEKpG_8wq6t6w@mail.gmail.com> (raw)
In-Reply-To: <20201217162740.1452000-1-aford173@gmail.com>
On Thu, Dec 17, 2020 at 5:27 PM Adam Ford <aford173@gmail.com> wrote:
> The driver can request an optional clock for mclk.
> Update the txt file to reflect this.
>
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Adam Ford <aford173@gmail.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> --- a/Documentation/devicetree/bindings/sound/wm8962.txt
> +++ b/Documentation/devicetree/bindings/sound/wm8962.txt
> @@ -9,6 +9,9 @@ Required properties:
> - reg : the I2C address of the device.
>
> Optional properties:
> +
This blank line is not needed (but it will probably be removed during a
future txt-to-yaml conversion ;-)
> + - clocks : The clock source of the mclk
> +
> - spk-mono: This is a boolean property. If present, the SPK_MONO bit
> of R51 (Class D Control 2) gets set, indicating that the speaker is
> in mono mode.
> @@ -27,6 +30,7 @@ Example:
> wm8962: codec@1a {
> compatible = "wlf,wm8962";
> reg = <0x1a>;
> + clocks = <&clks IMX6QDL_CLK_CKO>;
>
> gpio-cfg = <
> 0x0000 /* 0:Default */
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2020-12-18 12:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 16:27 [PATCH] ASoC: wm8962: Add optional mclk device tree binding Adam Ford
2020-12-18 12:58 ` Geert Uytterhoeven [this message]
2020-12-21 22:51 ` Rob Herring
2021-01-04 10:54 ` Charles Keepax
2021-01-04 17:39 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdV3WKFLPKf_6nVc0bX4wXe55GtKST9whiEKpG_8wq6t6w@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).