From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Zou Wei <zou_wei@huawei.com>
Cc: Vinod <vkoul@kernel.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Robin Murphy <robin.murphy@arm.com>,
dmaengine <dmaengine@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] dmaengine: rcar-dmac: Fix PM reference leak in rcar_dmac_probe()
Date: Mon, 31 May 2021 09:23:31 +0200 [thread overview]
Message-ID: <CAMuHMdV4fHpdm9tBMetde0ngRr8AuzcZ1sRFyFVKWCVg9TfspQ@mail.gmail.com> (raw)
In-Reply-To: <1622442963-54095-1-git-send-email-zou_wei@huawei.com>
On Mon, May 31, 2021 at 8:17 AM Zou Wei <zou_wei@huawei.com> wrote:
> pm_runtime_get_sync will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here.
> Fix it by replacing it with pm_runtime_resume_and_get to keep usage
> counter balanced.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-05-31 7:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 6:36 [PATCH -next] dmaengine: rcar-dmac: Fix PM reference leak in rcar_dmac_probe() Zou Wei
2021-05-31 7:23 ` Geert Uytterhoeven [this message]
2021-05-31 7:33 ` Laurent Pinchart
2021-06-03 11:07 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdV4fHpdm9tBMetde0ngRr8AuzcZ1sRFyFVKWCVg9TfspQ@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=dmaengine@vger.kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=vkoul@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).