From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Paul Cercueil <paul@crapouillou.net>,
RTCLINUX <rtc-linux@googlegroups.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] rtc: jz4740: make the driver builtin only
Date: Mon, 19 Dec 2016 09:03:17 +0100 [thread overview]
Message-ID: <CAMuHMdV5yOktsrBDVJy11PPX6ObuBKiyP6smqDTettoAg7WeiQ@mail.gmail.com> (raw)
In-Reply-To: <20161109003753.29759-2-alexandre.belloni@free-electrons.com>
Hi Alexandre,
On Wed, Nov 9, 2016 at 1:37 AM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> Since the driver is now calling machine_halt() that is not exported, it has
> to be built in the kernel. Building it as a module will fail at linking
> time.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> drivers/rtc/Kconfig | 5 +----
> drivers/rtc/rtc-jz4740.c | 10 +---------
> 2 files changed, 2 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 4259ce61c31b..24b0778f6e28 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1550,15 +1550,12 @@ config RTC_DRV_MPC5121
> will be called rtc-mpc5121.
>
> config RTC_DRV_JZ4740
> - tristate "Ingenic JZ4740 SoC"
> + bool "Ingenic JZ4740 SoC"
Just noticed RTC_DRV_JZ4740 flipped from m to y.
This is bad for distribution kernels.
Can't the driver just call kernel_halt() instead of machine_halt()?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2016-12-19 8:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 0:37 [PATCH 1/2] rtc: jz4740: remove unused EXPORT_SYMBOL Alexandre Belloni
2016-11-09 0:37 ` [PATCH 2/2] rtc: jz4740: make the driver builtin only Alexandre Belloni
2016-12-19 8:03 ` Geert Uytterhoeven [this message]
2016-12-19 9:47 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdV5yOktsrBDVJy11PPX6ObuBKiyP6smqDTettoAg7WeiQ@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).