From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752359AbdEELfG (ORCPT ); Fri, 5 May 2017 07:35:06 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:34527 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752101AbdEELfE (ORCPT ); Fri, 5 May 2017 07:35:04 -0400 MIME-Version: 1.0 In-Reply-To: <20170505112200.GA2939@infradead.org> References: <1493977751-19340-1-git-send-email-geert+renesas@glider.be> <20170505100729.GA21589@infradead.org> <20170505112200.GA2939@infradead.org> From: Geert Uytterhoeven Date: Fri, 5 May 2017 13:35:02 +0200 X-Google-Sender-Auth: ZnoDp-AOme7y-uIBRJ2C_CChAtY Message-ID: Subject: Re: [PATCH/RFC] signal: Export signal_wake_up_state() to modules To: Christoph Hellwig Cc: Geert Uytterhoeven , Ingo Molnar , Peter Zijlstra , Oleg Nesterov , Thomas Gleixner , "linux-kernel@vger.kernel.org" , linux-spi Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christoph, On Fri, May 5, 2017 at 1:22 PM, Christoph Hellwig wrote: > On Fri, May 05, 2017 at 01:08:47PM +0200, Geert Uytterhoeven wrote: >> Of course I can add a flag to indicate abortion, and just call complete_all(), >> but IMHO that's a bit silly, given wait_for_completion_interruptible() already >> provides this side channel information through -ERESTARTSYS. > > Even if this was the right channel (which I'm not sure about) it > should be provided as an abstract API operating on the completion. Hence my other question in the patch comments: | Is exporting signal_wake_up_state() an acceptable solution? | Alternatively, I can extract the code to abort an completion into a | generic abort_completion() function, and export that. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds