From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A76B8C352AA for ; Tue, 1 Oct 2019 09:03:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A2A521872 for ; Tue, 1 Oct 2019 09:03:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733285AbfJAJDu (ORCPT ); Tue, 1 Oct 2019 05:03:50 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:34598 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726568AbfJAJDt (ORCPT ); Tue, 1 Oct 2019 05:03:49 -0400 Received: by mail-ot1-f66.google.com with SMTP id m19so10913880otp.1; Tue, 01 Oct 2019 02:03:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tHb/q0D5mq2W+1z309ghRX/uOTtJacVT4nymLRBbTcY=; b=htkYd76D3kiDKEcy1bWVrY8+LBE/JTkBI+mpbmAmo2K653WzDQPZopJzPaUzyvcsD8 PUcIsjBHr4bk3NFJ5aX9ecsYZIv44d0o1Kl3tC6e6kB+LWm2ydN6iL7CNkI3TsOpGpB5 QY1OHSFgiZmHAnudnKRjUyL4CU27rK2x+dLLeeG1Eu19JwE06buCpYwGOrXicxUNlZZv ttrROxujt0T89cVt+1FEVtNTp2GqwqN01vxkFoFknhLC+bA7Qb297JsqydOuxaKuJsM5 v93nTjBmphU/RKczONQdAaFyp8Fucjeq3t7XyEDX2qk3aNsaGSYw36250H48rEzIDLid 4G2Q== X-Gm-Message-State: APjAAAWlkXeMrrIqMKKayfl1MDbu8F7jjCsSTihgEGNfhmXYf6NwYbgE uT7g7pqxhSt5IdIZRwCnyl3+jZUMhf8pa4tqo7s= X-Google-Smtp-Source: APXvYqyt8Fr5MNj8xgi9zNhfzNfGel2OzKPctcEPWiUOWLO4+kzE7HEg5SIyhaqF7N+eaUzd0/bjIui+DRWnMOK6Apw= X-Received: by 2002:a9d:404d:: with SMTP id o13mr17494480oti.39.1569920628345; Tue, 01 Oct 2019 02:03:48 -0700 (PDT) MIME-Version: 1.0 References: <20190812150452.27983-1-ard.biesheuvel@linaro.org> <20190812150452.27983-5-ard.biesheuvel@linaro.org> In-Reply-To: From: Geert Uytterhoeven Date: Tue, 1 Oct 2019 11:03:37 +0200 Message-ID: Subject: Re: [PATCH 4/5] efi: Export Runtime Configuration Interface table to sysfs To: Ard Biesheuvel Cc: Narendra K , linux-efi , Ingo Molnar , Thomas Gleixner , Linux Kernel Mailing List , James Morse , Mario Limonciello , Xiaofei Tan Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ard, On Tue, Oct 1, 2019 at 10:54 AM Ard Biesheuvel wrote: > On Tue, 1 Oct 2019 at 10:51, Geert Uytterhoeven wrote: > > On Mon, Aug 12, 2019 at 5:07 PM Ard Biesheuvel > > wrote: > > > From: Narendra K > > > > > > System firmware advertises the address of the 'Runtime > > > Configuration Interface table version 2 (RCI2)' via > > > an EFI Configuration Table entry. This code retrieves the RCI2 > > > table from the address and exports it to sysfs as a binary > > > attribute 'rci2' under /sys/firmware/efi/tables directory. > > > The approach adopted is similar to the attribute 'DMI' under > > > /sys/firmware/dmi/tables. > > > > > > RCI2 table contains BIOS HII in XML format and is used to populate > > > BIOS setup page in Dell EMC OpenManage Server Administrator tool. > > > The BIOS setup page contains BIOS tokens which can be configured. > > > > > > Signed-off-by: Narendra K > > > Reviewed-by: Mario Limonciello > > > Signed-off-by: Ard Biesheuvel > > > > Thanks, this is now commit 1c5fecb61255aa12 ("efi: Export Runtime > > Configuration Interface table to sysfs"). > > > > > --- a/drivers/firmware/efi/Kconfig > > > +++ b/drivers/firmware/efi/Kconfig > > > @@ -180,6 +180,19 @@ config RESET_ATTACK_MITIGATION > > > have been evicted, since otherwise it will trigger even on clean > > > reboots. > > > > > > +config EFI_RCI2_TABLE > > > + bool "EFI Runtime Configuration Interface Table Version 2 Support" > > > + help > > > + Displays the content of the Runtime Configuration Interface > > > + Table version 2 on Dell EMC PowerEdge systems as a binary > > > + attribute 'rci2' under /sys/firmware/efi/tables directory. > > > + > > > + RCI2 table contains BIOS HII in XML format and is used to populate > > > + BIOS setup page in Dell EMC OpenManage Server Administrator tool. > > > + The BIOS setup page contains BIOS tokens which can be configured. > > > + > > > + Say Y here for Dell EMC PowerEdge systems. > > > > A quick Google search tells me these are Intel Xeon. > > Are arm/arm64/ia64 variants available, too? > > If not, this should be protected by "depends on x86" ("|| COMPILE_TEST"?). > > The code in question is entirely architecture agnostic, and defaults > to 'n', so I am not convinced this is needed. (It came up in the > review as well) "make oldconfig" still asks me the question on e.g. arm64, where it is irrelevant, until arm64 variants of the hardware show up. So IMHO it should have "depends on X86 || COMPILE_TEST". Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds