From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753083AbbEDNWW (ORCPT ); Mon, 4 May 2015 09:22:22 -0400 Received: from mail-ob0-f179.google.com ([209.85.214.179]:36334 "EHLO mail-ob0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752222AbbEDNWO (ORCPT ); Mon, 4 May 2015 09:22:14 -0400 MIME-Version: 1.0 In-Reply-To: <1430744021-4140-1-git-send-email-richard@nod.at> References: <1430744021-4140-1-git-send-email-richard@nod.at> Date: Mon, 4 May 2015 15:22:13 +0200 X-Google-Sender-Auth: ixrI8UbHLsXnayGbKN-XnWEGebk Message-ID: Subject: Re: [PATCH] hostfs: Use correct mask for file mode From: Geert Uytterhoeven To: Richard Weinberger Cc: uml-devel , "linux-kernel@vger.kernel.org" , markus.stenberg@iki.fi Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 4, 2015 at 2:53 PM, Richard Weinberger wrote: > --- a/fs/hostfs/hostfs_kern.c > +++ b/fs/hostfs/hostfs_kern.c > @@ -581,7 +581,7 @@ static int hostfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, > if (name == NULL) > goto out_put; > > - fd = file_create(name, mode & S_IFMT); > + fd = file_create(name, mode & 0777); "(S_IRWXU | S_IRWXG | S_IRWXO)"? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds