linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Stafford Horne <shorne@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jonas Bonn <jonas@southpole.se>, Christian Svensson <blue@cmd.nu>,
	openrisc@lists.librecores.org, Ingo Molnar <mingo@kernel.org>
Subject: Re: [OpenRISC] [PATCH 3/3] openrisc: Export symbols needed by modules
Date: Tue, 14 Mar 2017 16:25:30 +0100	[thread overview]
Message-ID: <CAMuHMdVR5xL4SDD7GTd5JdGfhHLGuVvM7v0m-k2iJAd6U21sUg@mail.gmail.com> (raw)
In-Reply-To: <05e67e380f8a29ce479a180a3bbd145f30236b16.1489502779.git.shorne@gmail.com>

Hi Stafford,

On Tue, Mar 14, 2017 at 3:56 PM, Stafford Horne <shorne@gmail.com> wrote:
> This was detected by allmodconfig, errors reported:
>
>  ERROR: "empty_zero_page" [net/ceph/libceph.ko] undefined!
>  ERROR: "__ucmpdi2" [lib/842/842_decompress.ko] undefined!
>  ERROR: "empty_zero_page" [fs/nfs/objlayout/objlayoutdriver.ko] undefined!
>  ERROR: "empty_zero_page" [fs/exofs/exofs.ko] undefined!
>  ERROR: "empty_zero_page" [fs/crypto/fscrypto.ko] undefined!
>  ERROR: "__ucmpdi2" [fs/btrfs/btrfs.ko] undefined!
>  ERROR: "pm_power_off" [drivers/regulator/act8865-regulator.ko] undefined!
>
> Signed-off-by: Stafford Horne <shorne@gmail.com>

> --- a/arch/openrisc/kernel/or32_ksyms.c
> +++ b/arch/openrisc/kernel/or32_ksyms.c
> @@ -42,6 +42,11 @@ DECLARE_EXPORT(__muldi3);
>  DECLARE_EXPORT(__ashrdi3);
>  DECLARE_EXPORT(__ashldi3);
>  DECLARE_EXPORT(__lshrdi3);
> +DECLARE_EXPORT(__ucmpdi2);
> +
> +extern unsigned long empty_zero_page[2048];

Can't you #include <asm/pgtable.h> instead of adding a forward
declaration?

> +EXPORT_SYMBOL(empty_zero_page);

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2017-03-14 15:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-14 14:56 [PATCH 0/3] Openrisc fixes for 4.11 Stafford Horne
2017-03-14 14:56 ` [PATCH 1/3] openrisc: xchg: fix `computed is not used` warning Stafford Horne
2017-03-14 14:56 ` [PATCH 2/3] openrisc: fix issue handling 8 byte get_user calls Stafford Horne
2017-03-14 14:56 ` [PATCH 3/3] openrisc: Export symbols needed by modules Stafford Horne
2017-03-14 15:25   ` Geert Uytterhoeven [this message]
2017-03-14 22:17     ` [OpenRISC] " Stafford Horne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdVR5xL4SDD7GTd5JdGfhHLGuVvM7v0m-k2iJAd6U21sUg@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=blue@cmd.nu \
    --cc=jonas@southpole.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=openrisc@lists.librecores.org \
    --cc=shorne@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).