From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org,
Nicolin Chen <nicoleotsuka@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>,
Shengjiu Wang <shengjiu.wang@nxp.com>,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH] ASoC: fsl: add COMPILE_TEST for SND_SOC_FSL_ASRC
Date: Mon, 4 Oct 2021 09:17:22 +0200 [thread overview]
Message-ID: <CAMuHMdVRJ4kY1vncgm3jn=p1gYzYQC7C9E3dv+KoYauJgjL=fw@mail.gmail.com> (raw)
In-Reply-To: <20211003030404.32707-1-rdunlap@infradead.org>
Hi Randy,
On Sun, Oct 3, 2021 at 5:04 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> Geert pointed out that since sound/soc has the soc_dummy_driver for
> NO_DMA platforms, it is possible (desirable) to have drivers that
> depend on HAS_DMA to alternately depend on COMPILE_TEST.
Actually I had never heard about the soc_dummy_driver before ;-)
I did know about the dummies in include/linux/dma-mapping.h.
> This means that SND_ATMEL_FSL_ASRC can depend on HAS_DMA || COMPIE_TEST.
COMPILE_TEST
> Fixes: 121a01521b1e ("ASoC: fsl: fix build failure")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> --- linux-next-20211001.orig/sound/soc/fsl/Kconfig
> +++ linux-next-20211001/sound/soc/fsl/Kconfig
> @@ -5,7 +5,7 @@ comment "Common SoC Audio options for Fr
>
> config SND_SOC_FSL_ASRC
> tristate "Asynchronous Sample Rate Converter (ASRC) module support"
> - depends on HAS_DMA
> + depends on HAS_DMA || COMPILE_TEST
> select REGMAP_MMIO
> select SND_SOC_GENERIC_DMAENGINE_PCM
> help
The actual change LGTM, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2021-10-04 7:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 3:04 [PATCH] ASoC: fsl: add COMPILE_TEST for SND_SOC_FSL_ASRC Randy Dunlap
2021-10-04 7:17 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdVRJ4kY1vncgm3jn=p1gYzYQC7C9E3dv+KoYauJgjL=fw@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
--cc=rdunlap@infradead.org \
--cc=shengjiu.wang@nxp.com \
--cc=sudip.mukherjee@codethink.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).