From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35E6EC07E97 for ; Sat, 3 Jul 2021 08:50:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 145E76121E for ; Sat, 3 Jul 2021 08:50:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229981AbhGCIwj (ORCPT ); Sat, 3 Jul 2021 04:52:39 -0400 Received: from mail-vs1-f42.google.com ([209.85.217.42]:37860 "EHLO mail-vs1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229811AbhGCIwh (ORCPT ); Sat, 3 Jul 2021 04:52:37 -0400 Received: by mail-vs1-f42.google.com with SMTP id r24so1639324vsg.4; Sat, 03 Jul 2021 01:50:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ztvTWAqkHN2mDtjML2AdkD2LHf36o5PEQqo09qwLkPY=; b=VbNHRivAOWRQuNbOBkFVY4Nk8lTQmUuaGckyKlEHwlLJSVJx1lpxXtxLeCs+lmEwV/ ClQozK2JfMFhgl0K1pJ4aAajetRO958Aj0TvzDIBfNfNTrASngUFQBRXYwsJw4xgIw10 fgouUpVyz8y+iVBE8Tqs6JZTdsc3oDLy9mb7FOvH03adSCV/5SLzYY96d3TDQGkxnKD3 wBr7ETfDBwqvHK+0exNuLf2LtZgiP5QN1GthSw4P6plTcAQdZeh4UcSnkYDpwbSBZ3OR ofkCAbCm2rziaRdCbRtStPhdlzmc69hOLDwbYKOCw+nuSRWdFO5vwZ5AjsYKXcy2r4K5 fzWw== X-Gm-Message-State: AOAM530553P6BEa/3mxIZKMMGIjHOoP2OQVYhOGBQLQsdZY6bRMFUnBi 2Q4mwBeeIEzwKaQ9XT5nCyLGEDRCyx0dHiT3ta4= X-Google-Smtp-Source: ABdhPJyuUXkzJRe7nyGQY7VgkmHMTPL/ZKX7ox8bFgwnO/Xk8lPPexJD9V2v7FD0qLeUSgwjtNu/9IKshQ+B396Uvoc= X-Received: by 2002:a67:3c2:: with SMTP id 185mr3311187vsd.42.1625302203003; Sat, 03 Jul 2021 01:50:03 -0700 (PDT) MIME-Version: 1.0 References: <20210701002037.912625-1-drew@beagleboard.org> <20210701002037.912625-2-drew@beagleboard.org> <20210702205622.GA1035183@x1> <20210703064600.GA1050194@x1> In-Reply-To: <20210703064600.GA1050194@x1> From: Geert Uytterhoeven Date: Sat, 3 Jul 2021 10:49:51 +0200 Message-ID: Subject: Re: [RFC PATH 1/2] dt-bindings: gpio: add starfive,jh7100-gpio bindings To: Drew Fustini Cc: Rob Herring , Linus Walleij , Bartosz Golaszewski , Paul Walmsley , Palmer Dabbelt , Michael Zhu , Fu Wei , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , linux-riscv , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Huan Feng Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Drew, On Sat, Jul 3, 2021 at 8:46 AM Drew Fustini wrote: > On Fri, Jul 02, 2021 at 11:03:56PM +0200, Geert Uytterhoeven wrote: > > On Fri, Jul 2, 2021 at 10:56 PM Drew Fustini wrote: > > > On Thu, Jul 01, 2021 at 10:34:56AM +0200, Geert Uytterhoeven wrote: > > > > On Thu, Jul 1, 2021 at 2:22 AM Drew Fustini wrote: > > > > > Add bindings for the GPIO controller in the StarFive JH7100 SoC [1]. > > > > > > > > > > [1] https://github.com/starfive-tech/beaglev_doc > > > > > > > > > > Signed-off-by: Drew Fustini > > > > > Signed-off-by: Huan Feng > > > > > > > > Thanks for your patch! > > > > > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/gpio/starfive,jh7100-gpio.yaml > > > > > @@ -0,0 +1,60 @@ > > > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > > > +%YAML 1.2 > > > > > +--- > > > > > +$id: http://devicetree.org/schemas/gpio/starfive,jh7100-gpio.yaml# > > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > > + > > > > > +title: StarFive JH7100 GPIO controller > > > > > + > > > > > +maintainers: > > > > > + - Huan Feng > > > > > + - Drew Fustini > > > > > + > > > > > +properties: > > > > > + compatible: > > > > > + items: > > > > > + - const: starfive,jh7100-gpio > > > > > + > > > > > + reg: > > > > > + maxItems: 1 > > > > > + > > > > > + interrupts: > > > > > + description: > > > > > + Interrupt mapping, one per GPIO. Maximum 32 GPIOs. > > > > > + minItems: 1 > > > > > + maxItems: 32 > > > > > > > > What about clocks and resets? > > > But I am not sure how reset would work? > > > > That should become "resets = <&rstgen JH7100_RSTN_GPIO_APB>", > > but we don't have the reset controller in Linux yet (we do in barebox). > > Do you think I should add reset item like this? > > resets: > maxItems: 1 > > I suppose this is supposed to describe the hardware and it shouldn't > matter whether or not Linux uses the property, right? Exactly. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds