From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C43BC433E2 for ; Thu, 3 Sep 2020 10:19:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 626BA20767 for ; Thu, 3 Sep 2020 10:19:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726891AbgICKTC (ORCPT ); Thu, 3 Sep 2020 06:19:02 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:34568 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726479AbgICKS5 (ORCPT ); Thu, 3 Sep 2020 06:18:57 -0400 Received: by mail-oi1-f195.google.com with SMTP id z22so2609053oid.1; Thu, 03 Sep 2020 03:18:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/K2TceG+YMiMk03lA1/MkZv11rftVfSaLBq2a+jxQc8=; b=qaaBS6RtHt1XYsqBC1a7I57NwwAEXblT8/S9by8t2/hUFF0xKlgoJv6z2P7QMLw7AX Y0XXBb/XwDLGowjUZvpiRNjceI1s5ZWDXm0YIQKaULmI11vEXkWuoI5T8g67Bn626I6S pujx5ZtFZLfR9uXLSi+EAuxNV1UCN8Q6Rb0xcbZbnEdiJJtSatq9omYuUOyodHGbtpxn qLvw0ATUW6qjizwkzGp99dQpOMlVcojra82vEp/79Xp4/5CRrKda8E70ZdGLzisoRzXl 1zHXjtjIlu8xnQ5y3sTuBmzP2o+q2xhOSUpmbuKbQULdS5gC0+lbCArp3ayXsXoL031A jjeQ== X-Gm-Message-State: AOAM5319hro6XSn7ACOjCMX5KEGuGI9UVKfdaqMNG5b2/dJ/JRUUhGqv IPAFiLxfHdsA8xUume6SV4Hpp7DW79BRlJaUBY+rQG2fP0A= X-Google-Smtp-Source: ABdhPJygFHNDUkjk3+rmdBnoZmAJdF/YWtr4NhfoiZrjCH9Eq7jvuwgTPXwEDXAMPSmAWyXJS+rtQBViBj54DoQym+g= X-Received: by 2002:aca:52d6:: with SMTP id g205mr1540672oib.54.1599128336542; Thu, 03 Sep 2020 03:18:56 -0700 (PDT) MIME-Version: 1.0 References: <20200825162718.5838-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20200825162718.5838-2-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: <20200825162718.5838-2-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Geert Uytterhoeven Date: Thu, 3 Sep 2020 12:18:45 +0200 Message-ID: Subject: Re: [PATCH 1/4] ARM: dts: r8a7742-iwg21d-q7: Enable PCIe Controller To: Lad Prabhakar Cc: Magnus Damm , Rob Herring , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Prabhakar Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Prabhakar, On Tue, Aug 25, 2020 at 6:28 PM Lad Prabhakar wrote: > Enable PCIe Controller and set PCIe bus clock frequency. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Chris Paterson Reviewed-by: Geert Uytterhoeven i.e. will queue in renesas-devel for v5.10. One thing to double-check below. > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts > @@ -238,6 +238,18 @@ > /* status = "okay"; */ > }; > > +&pcie_bus_clk { > + clock-frequency = <100000000>; > +}; > + > +&pciec { > + /* SW2[6] determines which connector is activated > + * ON = PCIe X4 (connector-J7) > + * OFF = mini-PCIe (connector-J26) The table on page 14 says it's the other way around. According to the CBTL02042ABQ datasheet, PCIe_SEL = low selects the first channel (PCIe x4), while PCIe_SEL = high selects the second channel (mini-PCIe). Enabling the switch ties the signal low, so the table must be wrong. > + */ > + status = "okay"; > +}; > + > &pfc { > avb_pins: avb { > groups = "avb_mdio", "avb_gmii"; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds