From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752800AbeA3N7n (ORCPT ); Tue, 30 Jan 2018 08:59:43 -0500 Received: from mail-qk0-f194.google.com ([209.85.220.194]:42052 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751995AbeA3N7k (ORCPT ); Tue, 30 Jan 2018 08:59:40 -0500 X-Google-Smtp-Source: AH8x2260cfBIPdtAv9g9sF08KEhc5pNwFJ7+zVYHz3Xo0yUONRonOhRGL87K8uNfnfMVRnahOuFO/gKdqmHONLEJwLM= MIME-Version: 1.0 In-Reply-To: <20180130145626.7a108c64@bbrezillon> References: <1517318601-14793-1-git-send-email-geert@linux-m68k.org> <20180130144647.73a44b8d@xps13> <20180130145626.7a108c64@bbrezillon> From: Geert Uytterhoeven Date: Tue, 30 Jan 2018 14:59:37 +0100 X-Google-Sender-Auth: CBg5vZBfBED7ICWlV5SY8Cs5JGc Message-ID: Subject: Re: [PATCH] mtd: nand: MTD_NAND_MARVELL should depend on HAS_DMA To: Boris Brezillon Cc: Miquel Raynal , Richard Weinberger , MTD Maling List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 30, 2018 at 2:56 PM, Boris Brezillon wrote: > On Tue, 30 Jan 2018 14:46:47 +0100 > Miquel Raynal wrote: >> On Tue, 30 Jan 2018 14:23:21 +0100 >> Geert Uytterhoeven wrote: >> >> > If NO_DMA=y: >> > >> > ERROR: "bad_dma_ops" [drivers/mtd/nand/marvell_nand.ko] undefined! >> > >> > Add a dependency on HAS_DMA to fix this. >> > >> > Fixes: 02f26ecf8c772751 ("mtd: nand: add reworked Marvell NAND controller driver") >> > Signed-off-by: Geert Uytterhoeven >> > --- >> > drivers/mtd/nand/Kconfig | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig >> > index e6b8c59f2c0da7c0..736ac887303c88ba 100644 >> > --- a/drivers/mtd/nand/Kconfig >> > +++ b/drivers/mtd/nand/Kconfig >> > @@ -328,7 +328,7 @@ config MTD_NAND_MARVELL >> > tristate "NAND controller support on Marvell boards" >> > depends on PXA3xx || ARCH_MMP || PLAT_ORION || ARCH_MVEBU || \ >> > COMPILE_TEST >> > - depends on HAS_IOMEM >> > + depends on HAS_IOMEM && HAS_DMA >> >> I think this is more a coding issue than a Kconfig issue. AFAIR, none >> of the ARCH_MVEBU SoCs use DMA in conjunction with the NAND controller. >> PXA SoCs may use DMA (NFCv1 only) but this is not a hard requirement and >> the driver is supposed to support PIO mode in all situations. >> >> Can you please share your setup, the SoC, the configuration, >> maybe also the DT? > > I don't think Geert is testing on a real board. He's just enabling > COMPILE_TEST and can then select your driver. Which means you really > need this depends on HAS_DMA. Correct. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds