From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: linux-m68k <linux-m68k@lists.linux-m68k.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2][next] m68k: amiga: config: Mark expected switch fall-through
Date: Mon, 20 Apr 2020 19:48:39 +0200 [thread overview]
Message-ID: <CAMuHMdVaAV+bfEivzEpJh8SysVr7jziyBPknCUc1=DtOwu7ZrA@mail.gmail.com> (raw)
In-Reply-To: <50f85dd2-8250-1ca8-e2dd-4bba93a62736@embeddedor.com>
Hi Gustavo,
On Mon, Apr 20, 2020 at 6:03 PM Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
> On 4/20/20 02:17, Geert Uytterhoeven wrote:
> > On Fri, Mar 27, 2020 at 12:25 AM Gustavo A. R. Silva
> > <gustavo@embeddedor.com> wrote:
> >> Mark switch cases where we are expecting to fall through.
> >>
> >> This patch fixes the following warning (Building: allmodconfig m68k):
> >>
> >> arch/m68k/amiga/config.c: In function ‘amiga_identify’:
> >> ./arch/m68k/include/asm/amigahw.h:42:50: warning: this statement may fall through [-Wimplicit-fallthrough=]
> >> #define AMIGAHW_SET(name) (amiga_hw_present.name = 1)
> >> ~~~~~~~~~~~~~~~~~~~~~~~^~~~
> >> arch/m68k/amiga/config.c:223:3: note: in expansion of macro ‘AMIGAHW_SET’
> >> AMIGAHW_SET(PCMCIA);
> >> ^~~~~~~~~~~
> >> arch/m68k/amiga/config.c:224:2: note: here
> >> case AMI_500:
> >> ^~~~
> >>
> >> Replace the existing /* fall through */ comments and fix the issue above
> >> by using the new pseudo-keyword fallthrough;
> >>
> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > i.e. will queue in the m68k for-v5.8 branch.
> >
>
> Geert,
>
> I wonder if you received the first patch of the series.
No I haven't, and lore also only has the cover latter and patch 2/2:
https://lore.kernel.org/linux-m68k/cover.1585264062.git.gustavo@embeddedor.com/
Can you please resend? Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2020-04-20 17:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 23:23 [PATCH 0/2][next] m68k: amiga: config: Use flexible-array member and mark expected switch fall-through Gustavo A. R. Silva
2020-03-26 23:29 ` [PATCH 2/2][next] m68k: amiga: config: Mark " Gustavo A. R. Silva
2020-04-20 7:17 ` Geert Uytterhoeven
2020-04-20 16:07 ` Gustavo A. R. Silva
2020-04-20 17:48 ` Geert Uytterhoeven [this message]
2020-04-20 18:15 ` Gustavo A. R. Silva
2020-04-20 18:14 ` [PATCH RESEND 1/2][next] m68k: amiga: config: Replace zero-length array with flexible-array member Gustavo A. R. Silva
2020-04-21 7:06 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdVaAV+bfEivzEpJh8SysVr7jziyBPknCUc1=DtOwu7ZrA@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).