From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752688AbcCGL1t (ORCPT ); Mon, 7 Mar 2016 06:27:49 -0500 Received: from mail-ig0-f180.google.com ([209.85.213.180]:33919 "EHLO mail-ig0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752535AbcCGL1i (ORCPT ); Mon, 7 Mar 2016 06:27:38 -0500 MIME-Version: 1.0 In-Reply-To: <1457104420-18350-1-git-send-email-robh@kernel.org> References: <1457104420-18350-1-git-send-email-robh@kernel.org> Date: Mon, 7 Mar 2016 12:27:36 +0100 X-Google-Sender-Auth: CTq5wOrHKTQL9wVA19G5QH84vj0 Message-ID: Subject: Re: [PATCH] scripts/dtc: Update to upstream version 53bf130b1cdd From: Geert Uytterhoeven To: Rob Herring Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On Fri, Mar 4, 2016 at 4:13 PM, Rob Herring wrote: > Sync to upstream dtc commit 53bf130b1cdd ("libfdt: simplify > fdt_node_check_compatible()"). This adds the following commits from > upstream: > > 53bf130 libfdt: simplify fdt_node_check_compatible() > c9d9121 Warn on node name unit-address presence/absence mismatch > 2e53f9d Catch unsigned 32bit overflow when parsing flattened device tree offsets > > Signed-off-by: Rob Herring > --- > As usual, this is just an automated copy of upstream dtc into the kernel > tree. The changeset is small enough that I have left it here. > > The main reason for this sync is to pick-up the new unit-address > warnings. I gave this a try. Obviously it finds many abuses that should be fixed. However, I'm wondering about the following, where the unit-address is just used to distinguish between multiple instances: Warning (unit_address_vs_reg): Node /cache-controller@0 has a unit name, but no reg property compatible = "cache"; Warning (unit_address_vs_reg): Node /regulator@1 has a unit name, but no reg property compatible = "regulator-fixed" Warning (unit_address_vs_reg): Node /i2c@2 has a unit name, but no reg property compatible = "i2c-gpio" How should these be fixed? BTW, there seems to be a missing dependency of the DTBs on the dtc itself. Applying your patch and running "make dtbs" didn't rebuilt any DTBs. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds