From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6D44C433E0 for ; Mon, 8 Jun 2020 07:33:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC6A320760 for ; Mon, 8 Jun 2020 07:33:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729023AbgFHHdT (ORCPT ); Mon, 8 Jun 2020 03:33:19 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:40808 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728954AbgFHHdS (ORCPT ); Mon, 8 Jun 2020 03:33:18 -0400 Received: by mail-ot1-f68.google.com with SMTP id s13so12843918otd.7; Mon, 08 Jun 2020 00:33:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u0pDWBHAPx+7BsUGPboybuFRpJCeYypkd7+L0T1+1hA=; b=oZJFmRsqkC7WVTHqG37nSrj9cpZvlLLmeRnii8D45+r9WBxgzLzEIKzacBiGOC+xSc 7QLSX3Aet+6nV/MxcVW0IQc0cc/GuJTaw+XDGJLstyqFIKmqZuxCZaFsFAcg7ZLVb8fO HES2ogGz5Bq5SQFVL1ICq+ghpGrVjZvO0Bz1qicIsd7QhXwD/vzPfmbTIyS+W6/nBGQx MIIml8uCZ/jFFpLH4COlBShjagMPW1Js/J3rWN89i2weyumVGFL6lvhzXNmr+WaT8KlT 1utWOQX8NZ6BjEKnfdLEnU0Zkc/BFdmO3wyyP6j7nZXXavnjQhREJK8/6+BEte40a18V HQBg== X-Gm-Message-State: AOAM530gwEGePNLYuJZxwcfPChzmudmm7VD0yI78xPheMv3GAc4ovHbb uGEksWUWsvehUNIk/or9zUs0stPklsOOTLODtgo= X-Google-Smtp-Source: ABdhPJx/fhLXlHeev7ggIXtVp/AlQjYjBTTRXtndVnos9jVKuUhGarboOoPZ+V1D54NOAlAJ4cBMQFBAGRyZ+MtbXFo= X-Received: by 2002:a9d:c29:: with SMTP id 38mr15586831otr.107.1591601597506; Mon, 08 Jun 2020 00:33:17 -0700 (PDT) MIME-Version: 1.0 References: <20200604233003.GA102768@rikard> <20200607203411.70913-1-rikard.falkeborn@gmail.com> <20200607203411.70913-2-rikard.falkeborn@gmail.com> In-Reply-To: <20200607203411.70913-2-rikard.falkeborn@gmail.com> From: Geert Uytterhoeven Date: Mon, 8 Jun 2020 09:33:05 +0200 Message-ID: Subject: Re: [PATCH v2 2/2] bits: Add tests of GENMASK To: Rikard Falkeborn Cc: Andrew Morton , Andy Shevchenko , Arnd Bergmann , emil.l.velikov@gmail.com, Kees Cook , Linus Walleij , Linux-Arch , Linux Kernel Mailing List , kbuild test robot , syednwaris@gmail.com, William Breathitt Gray , Masahiro Yamada Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Richard, Thanks for your patch! On Sun, Jun 7, 2020 at 10:35 PM Rikard Falkeborn wrote: > Add tests of GENMASK and GENMASK_ULL. > > A few test cases that should fail compilation are provided under ifdef. It doesn't hurt to mention the name of the #ifdef here. > Suggested-by: Andy Shevchenko > Signed-off-by: Rikard Falkeborn > --- /dev/null > +++ b/lib/test_bits.c > @@ -0,0 +1,73 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Test cases for functions and macrso in bits.h > + */ > + > +#include > +#include > + > + > +void genmask_test(struct kunit *test) > +{ > + KUNIT_EXPECT_EQ(test, 1ul, GENMASK(0, 0)); > + KUNIT_EXPECT_EQ(test, 3ul, GENMASK(1, 0)); > + KUNIT_EXPECT_EQ(test, 6ul, GENMASK(2, 1)); > + KUNIT_EXPECT_EQ(test, 0xFFFFFFFFul, GENMASK(31, 0)); > + > +#ifdef TEST_BITS_COMPILE "#ifdef TEST_GENMASK_FAILURES"? > + /* these should fail compilation */ > + GENMASK(0, 1); > + GENMASK(0, 10); > + GENMASK(9, 10); > +#endif Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds