From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E10E6C433DF for ; Mon, 1 Jun 2020 09:13:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9E1420734 for ; Mon, 1 Jun 2020 09:13:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726327AbgFAJNH (ORCPT ); Mon, 1 Jun 2020 05:13:07 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:39561 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726225AbgFAJNG (ORCPT ); Mon, 1 Jun 2020 05:13:06 -0400 Received: by mail-ot1-f65.google.com with SMTP id g5so6915480otg.6 for ; Mon, 01 Jun 2020 02:13:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZlOPT56h6/JCVyC/ykPNuYWjyEpIi1l0BN1rPEqbUPk=; b=oNMiWlrjumZjU1ElMQwXSTBUqdUDA9+ihHcKPqPpQ6MCgl7UCGS3X0dvJB3mcukwUc YnlTYUomCLun8WLbfU6PYzHiDCQK8H3pFS27YnWJbVOvFeE++ywOL/K4fAHK0JuOJyfn xw6oaZGvG+LxAS/m1Ph/fCKLCPUr5NPzzooQbHCtKbNp6yGQ5Y07EriNDlNL4CeegmjR LxSPMDlnM9P1etQnBAxEbbN8L26I70QRMqJU0FoeqPHRFrxOla/Ybz1JoC0Kd9X70BNe H88X4oUA7oc753idyLb8afC2M6jcpn9E+RmbmVppXls7yeTEj51yJwmuIHPGiz52RV0o PT6w== X-Gm-Message-State: AOAM530GCFiS/aEL1o0j5FW+RBYrUv7NATt0eKEcGCjQ7PC3CIlwiRDl s3DKGqGVU6MeNtkkA2qnErVVQ9lsS7u9ZHFQm5Q= X-Google-Smtp-Source: ABdhPJycnrO6S08ZVNAUz71DZKIbHz0tp5g1FNVtTPGR441oaBdHIHUOnsXiHZ992Gann3uIDUPazeuir0lHRiVw2fo= X-Received: by 2002:a9d:7e92:: with SMTP id m18mr15598801otp.145.1591002784675; Mon, 01 Jun 2020 02:13:04 -0700 (PDT) MIME-Version: 1.0 References: <0fb7fdcd99d7820bb27faf1f27f7f6f1923914ef.1590880623.git.fthain@telegraphics.com.au> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 1 Jun 2020 11:12:52 +0200 Message-ID: Subject: Re: [PATCH 8/8] macintosh/adb-iop: Implement SRQ autopolling To: Finn Thain Cc: Benjamin Herrenschmidt , Joshua Thompson , linux-m68k , Linux Kernel Mailing List , linuxppc-dev Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Finn, On Mon, Jun 1, 2020 at 2:15 AM Finn Thain wrote: > On Sun, 31 May 2020, Geert Uytterhoeven wrote: > > On Sun, May 31, 2020 at 1:20 AM Finn Thain wrote: > > > arch/m68k/include/asm/adb_iop.h | 1 + > > > drivers/macintosh/adb-iop.c | 32 ++++++++++++++++++++++++++------ > > > > As this header file is used by a single source file only, perhaps it > > should just be absorbed by the latter? > > Sure, it could be absorbed by both asm/mac_iop.h and > drivers/macintosh/adb-iop.c but I don't see the point... asm/mac_iop.h doesn't include asm/adb_iop.h (at least not in my tree, but perhaps you have plans to change that?), so there's only a single user. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds