From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753149AbcJCJfe (ORCPT <rfc822;w@1wt.eu>);
        Mon, 3 Oct 2016 05:35:34 -0400
Received: from mail-io0-f193.google.com ([209.85.223.193]:35591 "EHLO
        mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753087AbcJCJfT (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 3 Oct 2016 05:35:19 -0400
MIME-Version: 1.0
In-Reply-To: <20161003090736.19926-4-jslaby@suse.cz>
References: <20161003090736.19926-1-jslaby@suse.cz> <20161003090736.19926-4-jslaby@suse.cz>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Mon, 3 Oct 2016 11:35:17 +0200
X-Google-Sender-Auth: A4d17PSYXOcsDj2W_yljgBOLx5o
Message-ID: <CAMuHMdVv+z926OUd6v-P9CBEhKHWkFJFgLxdt=Cizw8JMh2VVg@mail.gmail.com>
Subject: Re: [PATCH -resend 4/6] mdacon: enable COMPILE_TEST build
To: Jiri Slaby <jslaby@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>,
        Linux Fbdev development list <linux-fbdev@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 3, 2016 at 11:07 AM, Jiri Slaby <jslaby@suse.cz> wrote:
> It can be built even on systems without ISA. So enable compile testing
> by specifying ISA || COMPILE_TEST.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: <linux-fbdev@vger.kernel.org>
> ---
>  drivers/video/console/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
> index 38da6e299149..7e9e8be24134 100644
> --- a/drivers/video/console/Kconfig
> +++ b/drivers/video/console/Kconfig
> @@ -48,7 +48,7 @@ config VGACON_SOFT_SCROLLBACK_SIZE
>          screenfuls of scrollback buffer
>
>  config MDA_CONSOLE
> -       depends on !M68K && !PARISC && ISA
> +       depends on !M68K && !PARISC && (ISA || COMPILE_TEST)

My first thought was

    depends on (!M68K && !PARISC && ISA) || COMPILE_TEST

but arch/m68k/include/asm/vga.h doesn't define VGA_MAP_MEM().
Adding #include <asm-generic/vga.h> at the end of arch/m68k/include/asm/vga.h
fixes that.

Do we want that?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds