From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18C90C433F5 for ; Tue, 3 May 2022 09:37:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233500AbiECJlY (ORCPT ); Tue, 3 May 2022 05:41:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233475AbiECJlS (ORCPT ); Tue, 3 May 2022 05:41:18 -0400 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD06032052; Tue, 3 May 2022 02:37:46 -0700 (PDT) Received: by mail-qt1-f173.google.com with SMTP id h3so8318979qtn.4; Tue, 03 May 2022 02:37:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mJS2PbQaE+cZgUG4vlX1mlz4wtA8LAYNn+L6mZu2IK4=; b=IkdKWMoXT0EFYliFo4gJNdonVyaOubKyISyZJifOlDW0LHPJ9PGrxDiFT4egHkKXBz fz4y2Y7NBWp6wDFkjYurjzfq/vp1D2rrkSlcQX45N1G2sxvfVVzFzRxfNKxlqe3vQgCL dqe/7wXUk1W6OZTxzmgNlKWRsm+qsHKaeT4CDqRDMg5teI8Mw7sCcL14pEl+saOF0zFo P/7ymh31h++4Y5xKiNs2/vTmM7q/6KqXJoe5lnY7CVyy2z521XP/vTqTNoEppfuhdBAh H73BjeSLMT6vToymZdDnR+sjz0+UaOgF1BCNT6h2wf3rodxKUZ/Wbfo6p/TnT+OK8zw/ RqPA== X-Gm-Message-State: AOAM5309Ahcjzkla0KuP2y6O0C0ctbFw4hDD22KtcvjRejlfT6dC8q6W UEKDeG4kD5KrlLsW/OE34sc/Rm3VqypazA== X-Google-Smtp-Source: ABdhPJzrZppVyLXFTNKY5hW5T0HmM/K6t//7bK71b2VkBzGFbwCPBlpt0D1+I/SvQ4jZiiNP8u4n7w== X-Received: by 2002:a05:622a:20a:b0:2f3:aa7d:626d with SMTP id b10-20020a05622a020a00b002f3aa7d626dmr5204636qtx.270.1651570665618; Tue, 03 May 2022 02:37:45 -0700 (PDT) Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com. [209.85.128.173]) by smtp.gmail.com with ESMTPSA id j6-20020a05620a146600b0069fc13ce217sm5511059qkl.72.2022.05.03.02.37.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 May 2022 02:37:44 -0700 (PDT) Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-2f7d19cac0bso173261257b3.13; Tue, 03 May 2022 02:37:44 -0700 (PDT) X-Received: by 2002:a81:547:0:b0:2f8:6e8:19d7 with SMTP id 68-20020a810547000000b002f806e819d7mr14558872ywf.383.1651570664082; Tue, 03 May 2022 02:37:44 -0700 (PDT) MIME-Version: 1.0 References: <20220429134143.628428-1-herve.codina@bootlin.com> <20220429134143.628428-4-herve.codina@bootlin.com> <29ba3db6-e5c7-06d3-29d9-918ee5b34555@linaro.org> <5a89e9bf-1004-500a-75e1-995732629937@linaro.org> In-Reply-To: <5a89e9bf-1004-500a-75e1-995732629937@linaro.org> From: Geert Uytterhoeven Date: Tue, 3 May 2022 11:37:31 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 2/6] dt-bindings: PCI: renesas,pci-rcar-gen2: Add device tree support for r9a06g032 To: Krzysztof Kozlowski Cc: Rob Herring , Herve Codina , Marek Vasut , Yoshihiro Shimoda , Bjorn Helgaas , Krzysztof Kozlowski , Magnus Damm , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , linux-pci , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Sergey Shtylyov , Thomas Petazzoni , Clement Leger , Miquel Raynal Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Tue, May 3, 2022 at 11:29 AM Krzysztof Kozlowski wrote: > On 03/05/2022 08:51, Geert Uytterhoeven wrote: > >>>> This should not be a reason why a property is or is not required. Either > >>>> this is required for device operation or not. If it is required, should > >>>> be in the bindings. Otherwise what are you going to do in the future? > >>>> Add a required property breaking the ABI? > >>> > >>> The problem is that there are no bindings for the reset controller > >>> (actually the reset controller feature of the system-controller) yet. > >>> Yeah, we can just add #reset-cells = <1> to the system-controller > >>> device node, but we cannot add the actual resets properties to the > >>> consumers, until the actual cell values are defined. > >> > >> Sounds like you should implement providers first. Or just live with the > >> warning as a reminder to implement the reset provider? > > > > I'd go for the latter. The upstream r9a06g032.dtsi is still under active > > development. Until very recently, the only device supported was the > > serial console. > > For clocks we use in such cases fixed-clock placeholders or empty > phandles. Maybe something like that would work here as well? I don't think that works for resets. Besides, the driver doesn't need or use the reset anyway. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds