From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Valentin CARON <valentin.caron@foss.st.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>,
Jiri Slaby <jirislaby@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Erwan Le Ray <erwan.leray@foss.st.com>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
linux-stm32@st-md-mailman.stormreply.com,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH V2 3/3] serial: stm32: add earlycon support
Date: Thu, 14 Apr 2022 14:24:26 +0200 [thread overview]
Message-ID: <CAMuHMdVyScZaYPcRqcobnaC2LAdfV80KXzCnxwfBE9-Q+72OYQ@mail.gmail.com> (raw)
In-Reply-To: <b29dda44-1596-0456-7331-00012d740f06@foss.st.com>
Hi Valentin,
On Thu, Apr 14, 2022 at 2:17 PM Valentin CARON
<valentin.caron@foss.st.com> wrote:
> On 4/11/22 16:59, Geert Uytterhoeven wrote:
> > On Fri, Apr 8, 2022 at 3:14 PM Valentin Caron
> > <valentin.caron@foss.st.com> wrote:
> >> Add early console support in stm32 uart driver.
> >>
> >> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
> >> Signed-off-by: Valentin Caron <valentin.caron@foss.st.com>
> > Thanks for your patch!
> >
> >> --- a/Documentation/admin-guide/kernel-parameters.txt
> >> +++ b/Documentation/admin-guide/kernel-parameters.txt
> >> @@ -1264,6 +1264,12 @@
> >> address must be provided, and the serial port must
> >> already be setup and configured.
> >>
> >> + stm32,<addr>
> >> + Use early console provided by ST Microelectronics
> >> + serial driver for STM32 SoCs. A valid base address
> >> + must be provided, and the serial port must already
> >> + be setup and configured.
> > Why do you need this parameter?
> >
> > Given this driver uses DT, can't it figure out the serial port address
> > from chosen/stdout-path?
>
> I took the example of other serial drivers.
> Both methods work (with earlycon/stdout-path and with
> earlycon=stm32,0xXXXXXXX)
> but your right, the second will probably never used on this driver.
>
> Should I remove it ?
I think you should. The less platform-specific kernel parameters,
the better. And the less bad examples to copy from.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2022-04-14 12:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 12:26 [PATCH V2 0/3] serial: stm32: add earlycon and polling mode Valentin Caron
2022-04-08 12:26 ` [PATCH V2 1/3] serial: stm32: remove infinite loop possibility in putchar function Valentin Caron
2022-04-08 12:26 ` [PATCH V2 2/3] serial: stm32: add KGDB support Valentin Caron
2022-04-08 12:26 ` [PATCH V2 3/3] serial: stm32: add earlycon support Valentin Caron
2022-04-11 14:59 ` Geert Uytterhoeven
2022-04-14 12:17 ` Valentin CARON
2022-04-14 12:24 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdVyScZaYPcRqcobnaC2LAdfV80KXzCnxwfBE9-Q+72OYQ@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=alexandre.torgue@foss.st.com \
--cc=corbet@lwn.net \
--cc=erwan.leray@foss.st.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=valentin.caron@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).