From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02EC5C43215 for ; Tue, 19 Nov 2019 18:56:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DFC662241B for ; Tue, 19 Nov 2019 18:56:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727239AbfKSS4F (ORCPT ); Tue, 19 Nov 2019 13:56:05 -0500 Received: from mail-ot1-f68.google.com ([209.85.210.68]:42558 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726892AbfKSS4F (ORCPT ); Tue, 19 Nov 2019 13:56:05 -0500 Received: by mail-ot1-f68.google.com with SMTP id b16so18855818otk.9; Tue, 19 Nov 2019 10:56:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CCMimOxx1V+1wuiFXabtOOmc4F+FlW5VrFGeJkEeb3g=; b=WU1aFvI96hM19+44aW8xWwhcFV+VkO2FaTZ3uvCD27r1LUKpWEDyf1yGPotkI04iXN oNyYacW2JY+SfP1HYc7Kl80zpQVgSlvXwgQfNGlsbeyd1jpTUsu5h0GiPwFMsODOcN0Y rFrafl2QQYOemVJgvUdjFycGnj3V0/bK0gUjlFm50I8ozVDDgqJRIZvEoE+VNEubJmTf +aY79/rc4k1cwjzSBG6I2KgOFrGff44FedjAk6KVaW3k/6mBT19XOfRxCBN81+jy1RDV +Vn3cv7dV/IqxYupuw5WPiQPOYjnbn2E05UpywBZilGvX3uBXuuh92wpNnZk+n4BvjZV Akyg== X-Gm-Message-State: APjAAAWRMWOWL8YAuNzq/kefTSi0ThdW0F9peTufJIxeJeS0xoEsGKxm lB041ecFtv6LQlXceQriXnMR+EH0IsWy89bmsUc= X-Google-Smtp-Source: APXvYqx9RerZ121T3Eq7XBfWuQsji+hUcMrbDd/mvJJNzps0Zuxlx3QL2Akjf/eIrhg+NcOQ2gFiiv9G2SJxxaTwvN8= X-Received: by 2002:a9d:5511:: with SMTP id l17mr4972413oth.145.1574189764218; Tue, 19 Nov 2019 10:56:04 -0800 (PST) MIME-Version: 1.0 References: <20191119112524.24841-1-geert+renesas@glider.be> <1afede33-897b-8718-d977-351357dffe4f@gmail.com> In-Reply-To: <1afede33-897b-8718-d977-351357dffe4f@gmail.com> From: Geert Uytterhoeven Date: Tue, 19 Nov 2019 19:55:53 +0100 Message-ID: Subject: Re: [PATCH] mdio_bus: Fix init if CONFIG_RESET_CONTROLLER=n To: Florian Fainelli Cc: Geert Uytterhoeven , YueHaibing , "David S . Miller" , Andrew Lunn , Heiner Kallweit , netdev , Linux-Renesas , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Florian, On Tue, Nov 19, 2019 at 7:05 PM Florian Fainelli wrote: > On 11/19/19 3:25 AM, Geert Uytterhoeven wrote: > > Commit 1d4639567d970de0 ("mdio_bus: Fix PTR_ERR applied after > > initialization to constant") accidentally changed a check from -ENOTSUPP > > to -ENOSYS, causing failures if reset controller support is not enabled. > > E.g. on r7s72100/rskrza1: > > > > sh-eth e8203000.ethernet: MDIO init failed: -524 > > sh-eth: probe of e8203000.ethernet failed with error -524 > > > > Fixes: 1d4639567d970de0 ("mdio_bus: Fix PTR_ERR applied after initialization to constant") > > Signed-off-by: Geert Uytterhoeven > > This has been fixed in the "net" tree with: > > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=075e238d12c21c8bde700d21fb48be7a3aa80194 Ah, hadn't seen that one. However, that one (a) keeps the unneeded check for -ENOSYS, and (b) carries a wrong Fixes tag. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds