From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Chen-Yu Tsai <wens@csie.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] simplefb: Disable and release clocks and regulators in destroy callback
Date: Wed, 7 Sep 2016 13:31:06 +0200 [thread overview]
Message-ID: <CAMuHMdW+a_GRiSdvCoehScjePXXHNgr-gFXkkYfXJhrPwLiJZw@mail.gmail.com> (raw)
In-Reply-To: <dc027024-c2ad-85fa-8671-53781c95c584@redhat.com>
Hi Hans,
On Wed, Sep 7, 2016 at 1:29 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> On 07-09-16 13:12, Geert Uytterhoeven wrote:
>> On Wed, Sep 7, 2016 at 11:09 AM, Chen-Yu Tsai <wens@csie.org> wrote:
>>> simplefb gets unregister when a proper framebuffer driver comes in and
>>> kicks it out. However the claimed clocks and regulators stay enabled
>>> as they are only released in the platform device remove function, which
>>> in theory would never get called.
>>>
>>> Move the clock/regulator cleanup into the framebuffer destroy callback,
>>> which gets called as part of the framebuffer unregister process.
>>
>>
>> Is this called before or after the new proper framebuffer driver kicks in?
>> If before, it may cause glitches.
>
>
> It is called by the new proper framebuffer driver's probe method,
> so it can make sure that it has already claimed / enabled the
> clocks/regulators before it calls remove_conlicting_framebuffers,
> avoiding the glitch.
OK, thx!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2016-09-07 11:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 9:09 [PATCH] simplefb: Disable and release clocks and regulators in destroy callback Chen-Yu Tsai
2016-09-07 9:31 ` Hans de Goede
2016-09-07 11:12 ` Geert Uytterhoeven
2016-09-07 11:29 ` Hans de Goede
2016-09-07 11:31 ` Geert Uytterhoeven [this message]
2016-09-27 8:22 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdW+a_GRiSdvCoehScjePXXHNgr-gFXkkYfXJhrPwLiJZw@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).