From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E8BEC433E0 for ; Tue, 5 Jan 2021 11:01:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E76DC229C9 for ; Tue, 5 Jan 2021 11:01:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729421AbhAELAx (ORCPT ); Tue, 5 Jan 2021 06:00:53 -0500 Received: from mail-oo1-f47.google.com ([209.85.161.47]:33841 "EHLO mail-oo1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729252AbhAELAw (ORCPT ); Tue, 5 Jan 2021 06:00:52 -0500 Received: by mail-oo1-f47.google.com with SMTP id x23so6992645oop.1; Tue, 05 Jan 2021 03:00:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jJeZsSi/01Cav7+K7JwyWm6MMO/wugP5/u44TAzN3Zk=; b=bXn/8DQAJvYYNed9CzrkSvhkHrz4Me1NEJST7kXxga5hsfrUicl6b3dVLW9A2/34gP I1QBwAkmaLr/Qza4V3X6hVtY2azkBlBnDR3cLcEMYodKBCygk8IuVsVP2Cmk01VIYP+H OBLzNS/r9QxXZXqCstEXDkMhHiEZwFN0GTcAMxZ/8MA1DhB0YjpsNGzI2HQ0km940lD3 8h24faL7uiwX8j0W+VIkcERKYcycAV8lLQmFiaR2gShlMis08VLasZmKXOpNWHTzKc44 FUt2s+Oe9JB9Mvc5aKNhRaM/whq2rIgNUlTj8Ui1t1b/liT7nGP8j97S9ww+LM5fdLjv Rnwg== X-Gm-Message-State: AOAM531dRMxQ9xwVq7WgEF9khNONEwbYz0RgBc8gc2LA7/Wyc52vALzu v++KdH1lSXu8ERiK8D+Aknm4/xRzjp7Ed0DBj2Cr6GYF X-Google-Smtp-Source: ABdhPJyv3C2eY2G954afrjNLNxBIHalBcC0Idl3e7QMA00wrpLCXxslJNj0HUWj/oVgZ6TDqNWO4sllpP3AnTy9GcNs= X-Received: by 2002:a4a:ca14:: with SMTP id w20mr52111506ooq.11.1609844411459; Tue, 05 Jan 2021 03:00:11 -0800 (PST) MIME-Version: 1.0 References: <20201223172505.34736-1-wsa+renesas@sang-engineering.com> <20201223172505.34736-5-wsa+renesas@sang-engineering.com> In-Reply-To: <20201223172505.34736-5-wsa+renesas@sang-engineering.com> From: Geert Uytterhoeven Date: Tue, 5 Jan 2021 12:00:00 +0100 Message-ID: Subject: Re: [PATCH 4/5] arm64: dts: renesas: Add I2C support for falcon board To: Wolfram Sang Cc: Linux-Renesas , Koji Matsuoka , Magnus Damm , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram, On Wed, Dec 23, 2020 at 6:25 PM Wolfram Sang wrote: > From: Koji Matsuoka > > Signed-off-by: Koji Matsuoka > [wsa: rebased] > Signed-off-by: Wolfram Sang Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts > +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts > @@ -21,6 +21,34 @@ chosen { > }; > }; > > +&i2c0 { > + pinctrl-0 = <&i2c0_pins>; > + pinctrl-names = "default"; > + > + status = "okay"; > + clock-frequency = <400000>; > +}; > + > +&i2c1 { > + pinctrl-0 = <&i2c1_pins>; > + pinctrl-names = "default"; > + > + status = "okay"; > + clock-frequency = <400000>; > +}; > + > +&pfc { > + i2c0_pins: i2c0 { > + groups = "i2c0"; > + function = "i2c0"; > + }; > + > + i2c1_pins: i2c1 { > + groups = "i2c1"; > + function = "i2c1"; > + }; > +}; > + BTW, why not adding i2c6, which also has slave devices connected to it? > &rwdt { > timeout-sec = <60>; > status = "okay"; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds