From: Geert Uytterhoeven <geert@linux-m68k.org>
To: wangjianli <wangjianli@cdjrlc.com>
Cc: Jacopo Mondi <jacopo@jmondi.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/renesas: fix repeated words in comments
Date: Mon, 22 Aug 2022 10:06:03 +0200 [thread overview]
Message-ID: <CAMuHMdWCJCcs4thnjuwa9ZpLCdtFgptLUd9eo_gAvuKwGhG-jw@mail.gmail.com> (raw)
In-Reply-To: <20220821145435.49842-1-wangjianli@cdjrlc.com>
Hi Wangjianli,
On Sun, Aug 21, 2022 at 4:58 PM wangjianli <wangjianli@cdjrlc.com> wrote:
> Delete the redundant word 'on'.
>
> Signed-off-by: wangjianli <wangjianli@cdjrlc.com>
Thanks for your patch!
> --- a/drivers/media/platform/renesas/renesas-ceu.c
> +++ b/drivers/media/platform/renesas/renesas-ceu.c
> @@ -1101,7 +1101,7 @@ static int ceu_open(struct file *file)
> return ret;
>
> mutex_lock(&ceudev->mlock);
> - /* Causes soft-reset and sensor power on on first open */
> + /* Causes soft-reset and sensor power on first open */
The double "on" is actually correct. Please ask yourself the question:
"When should the sensor be powered on?".
Answer: "On first open".
Personally, I would have written "power-on" instead of "power on"
(cfr. "soft-reset"), so perhaps it's a good idea to make that change,
to prevent the next person looking for double words falling for
this again?
> ret = pm_runtime_resume_and_get(ceudev->dev);
> mutex_unlock(&ceudev->mlock);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2022-08-22 8:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-21 14:54 [PATCH] platform/renesas: fix repeated words in comments wangjianli
2022-08-22 6:48 ` Jacopo Mondi
2022-08-22 8:06 ` Geert Uytterhoeven [this message]
2022-08-22 8:39 ` Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdWCJCcs4thnjuwa9ZpLCdtFgptLUd9eo_gAvuKwGhG-jw@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=jacopo@jmondi.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=wangjianli@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).