From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758124AbaKUJE4 (ORCPT ); Fri, 21 Nov 2014 04:04:56 -0500 Received: from mail-la0-f41.google.com ([209.85.215.41]:54085 "EHLO mail-la0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752836AbaKUJEv (ORCPT ); Fri, 21 Nov 2014 04:04:51 -0500 MIME-Version: 1.0 In-Reply-To: <546E0970.5090301@ti.com> References: <1415631557-22897-1-git-send-email-grygorii.strashko@ti.com> <1709760.E0jX3Myv0h@wuerfel> <546C7FDD.7030906@ti.com> <2900095.WIocOu7ue2@wuerfel> <546DD87B.3080806@ti.com> <546E0970.5090301@ti.com> Date: Fri, 21 Nov 2014 10:04:47 +0100 X-Google-Sender-Auth: wd5GmMpkhyeELIefWaoSCIYuq4A Message-ID: Subject: Re: [PATCH v4 1/2] ARM: keystone: pm: switch to use generic pm domains From: Geert Uytterhoeven To: Grygorii Strashko Cc: Ulf Hansson , Arnd Bergmann , Kevin Hilman , ssantosh@kernel.org, "Rafael J. Wysocki" , "linux-pm@vger.kernel.org" , Rob Herring , Grant Likely , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Dmitry Torokhov Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 20, 2014 at 4:32 PM, Grygorii Strashko wrote: >> That's indeed the tricky part. >> >> On shmobile, we just use the "NULL" clock, i.e. the first clock, for historical >> reasons. >> >> Using clock-names (e.g. "fck" and "pm") will conflict with existing bindings >> for devices that already mandate specific clock names. >> >> As the clock being a "PM" clock is a property of the clock provider >> (at last on shmobile), I originally came up with not handling it in DT, >> but advertising it in the clock provider driver: >> >>>> - first Geert Uytterhoeven proposed to use CLK_RUNTIME_PM there >>>> https://lkml.org/lkml/2014/11/6/319 > > As I mentioned previously I don't like it, because in many cases one driver is used for > all/set_of clocks which support gating function. As result, some sort of tables will > need to be created and maintained in code by these drivers per each SoC > (or even per each SoC revision) for identification that clock is "PM clock". That depends. On shmobile, there's a separate hardware module for those clocks, hence all clocks provided by drivers/clk/shmobile/clk-mstp.c are "PM" clocks. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds