From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932954AbeBUK0t (ORCPT ); Wed, 21 Feb 2018 05:26:49 -0500 Received: from mail-qk0-f193.google.com ([209.85.220.193]:43499 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932751AbeBUK0q (ORCPT ); Wed, 21 Feb 2018 05:26:46 -0500 X-Google-Smtp-Source: AG47ELvRBrsxkH7GAlt6MsrHX25597PdbbwKCHTFwlt0njzydCDG/A3/Hcc5VrETZZf6XEPs9/nr0CtGcMGOq6Iae6k= MIME-Version: 1.0 In-Reply-To: <20180220231046.32638-4-laurent.pinchart+renesas@ideasonboard.com> References: <20180220231046.32638-1-laurent.pinchart+renesas@ideasonboard.com> <20180220231046.32638-4-laurent.pinchart+renesas@ideasonboard.com> From: Geert Uytterhoeven Date: Wed, 21 Feb 2018 11:26:45 +0100 X-Google-Sender-Auth: KsfK_zOogbvvNeB7x1j044Ek74c Message-ID: Subject: Re: [PATCH v4 03/16] of: dynamic: Add __of_node_dupv() To: Laurent Pinchart Cc: DRI Development , Linux-Renesas , Pantelis Antoniou , Rob Herring , Frank Rowand , Matt Porter , Koen Kooi , Guenter Roeck , Marek Vasut , Wolfram Sang , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux I2C Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Laurent, On Wed, Feb 21, 2018 at 12:10 AM, Laurent Pinchart wrote: > From: Pantelis Antoniou > > Add an __of_node_dupv() private method and make __of_node_dup() use it. > This is required for the subsequent changeset accessors which will > make use of it. > > Signed-off-by: Pantelis Antoniou > Signed-off-by: Laurent Pinchart > --- > drivers/of/dynamic.c | 29 +++++++++++++++++++++++------ > 1 file changed, 23 insertions(+), 6 deletions(-) > > diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c > index 7bb33d22b4e2..4ffd04925fdf 100644 > --- a/drivers/of/dynamic.c > +++ b/drivers/of/dynamic.c > @@ -382,8 +382,9 @@ struct property *__of_prop_dup(const struct property *prop, gfp_t allocflags) > } > > /** > - * __of_node_dup() - Duplicate or create an empty device node dynamically. > - * @fmt: Format string (plus vargs) for new full name of the device node > + * __of_node_dupv() - Duplicate or create an empty device node dynamically. > + * @fmt: Format string for new full name of the device node > + * @vargs: va_list containing the arugments for the node full name > * > * Create an device tree node, either by duplicating an empty node or by allocating > * an empty one suitable for further modification. The node data are > @@ -391,17 +392,15 @@ struct property *__of_prop_dup(const struct property *prop, gfp_t allocflags) > * OF_DETACHED bits set. Returns the newly allocated node or NULL on out of > * memory error. > */ > -struct device_node *__of_node_dup(const struct device_node *np, const char *fmt, ...) > +struct device_node *__of_node_dupv(const struct device_node *np, static, cfr. https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/commit/?h=topic/overlays&id=c45324e1807dd708344c9a478b777b68aca11cdf Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds