From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 0/2] PM / core: genpd fix and pm_runtime_force_suspend|resume() rework
Date: Wed, 17 Jan 2018 10:14:23 +0100 [thread overview]
Message-ID: <CAMuHMdWR+V8d3geQutKr+f+e7+H2D9k-2_-5kJp-4n0rzMXoWA@mail.gmail.com> (raw)
In-Reply-To: <CAJZ5v0hEVdARvFQo7ma3F756aE0+3vbqu+-L7Ffw0rgpWYt2rA@mail.gmail.com>
Hi Rafael,
On Mon, Jan 15, 2018 at 5:17 PM, Rafael J. Wysocki <rafael@kernel.org> wrote:
> On Mon, Jan 15, 2018 at 3:26 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>> On 15 January 2018 at 14:22, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> [cut]
>
>>>
>>> I did miss a small difference in topology: in pm/linux-next, H3 has DMA
>>> enabled for SCIF2, while M3 hasn't (yet).
>>> With DMA enabled on M3, it fails in the same way.
>>>
>>> As genpd_resume_noirq() no longer calls pm_runtime_force_resume(),
>>> rcar_dmac_runtime_resume() is no longer called, and the DMAC's registers
>>> are no longer reinitialized after system resume, breaking the serial port.
>>
>> In drivers/dma/sh/rcar-dmac.c, I would try to replace the below line:
>> SET_SYSTEM_SLEEP_PM_OPS(rcar_dmac_sleep_suspend, rcar_dmac_sleep_resume)
>>
>> with:
>> SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume)
>
> Yes, that probably is the least intrusive thing that can be done to
> address the issue.
>
>> in case that may be too early to suspend the dma device (which is
>> rather common for dma devices) then try;
>>
>> SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume)
>
> Good suggestion, and I would go straight for it anyway.
>
> Geert, can you try if this works, please?
Works. Both using SET_SYSTEM_SLEEP_PM_OPS() and
SET_LATE_SYSTEM_SLEEP_PM_OPS(). But given this is a DMA engine
driver, I'd settle for the latter.
And I did verify doing so doesn't break the system without the patch
in $subject.
Thanks!
Will send a patch...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2018-01-17 9:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 13:00 [PATCH 0/2] PM / core: genpd fix and pm_runtime_force_suspend|resume() rework Rafael J. Wysocki
2018-01-12 13:10 ` [PATCH 1/2] PM / genpd: Stop/start devices without pm_runtime_force_suspend/resume() Rafael J. Wysocki
2018-01-12 14:07 ` Ulf Hansson
2018-01-12 13:12 ` [PATCH 2/2] PM / runtime: Rework pm_runtime_force_suspend/resume() Rafael J. Wysocki
2018-01-12 13:59 ` Ulf Hansson
2018-01-13 0:41 ` Rafael J. Wysocki
2018-01-12 14:31 ` [PATCH 0/2] PM / core: genpd fix and pm_runtime_force_suspend|resume() rework Geert Uytterhoeven
2018-01-13 0:38 ` Rafael J. Wysocki
2018-01-14 9:48 ` Geert Uytterhoeven
2018-01-15 0:04 ` Rafael J. Wysocki
2018-01-15 8:16 ` Geert Uytterhoeven
2018-01-15 13:22 ` Geert Uytterhoeven
2018-01-15 14:26 ` Ulf Hansson
2018-01-15 16:17 ` Rafael J. Wysocki
2018-01-17 9:14 ` Geert Uytterhoeven [this message]
2018-01-17 11:11 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdWR+V8d3geQutKr+f+e7+H2D9k-2_-5kJp-4n0rzMXoWA@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).