From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 223B9C43457 for ; Mon, 12 Oct 2020 13:16:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1B762065D for ; Mon, 12 Oct 2020 13:16:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388823AbgJLNQL (ORCPT ); Mon, 12 Oct 2020 09:16:11 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:34562 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388813AbgJLNQK (ORCPT ); Mon, 12 Oct 2020 09:16:10 -0400 Received: by mail-oi1-f193.google.com with SMTP id w204so3487215oiw.1; Mon, 12 Oct 2020 06:16:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sSubvuvsRqa9Us4jIiX4BQlzCXkcEfFKaZCMlzTTvKk=; b=j6tWp4Bdy7tcC/2fno9oBWheSYrIc09YUV9Q5qyVICuR8Se+dXOzNS66d+EcXiawip z9rwPtcBkza4trcTwBGyttivmpgYOhar4NSAG7ONq6HykfphbWR5W4VrcBXJJXicMl5Q 2mKIhUIltYe7L+1eW7WFRZ47VQ/lmGIfDqhKqZ3D0jKWiYdmK4T/ChBYUm/vB8HWp3X9 rhuQS8CEQRJ9woE9WegmIdUubeseKVvQ/g0ZROO9jLcAKYHH4QmaUwcUcVWk+NK9szk0 EH+WXFVI7wwx44wGyrMoi+ahV9y/FE5wEfdDn93OC9twZrpqdAJXmnL8BM4aQzK2Wkzk D1yQ== X-Gm-Message-State: AOAM531u6hG68dqTA4yx9mQVSPAqGKrsNQlMaerlN2UFoLyWlLP1TXu7 thzq1UUvrW3LJ1MxS3hE51jdmcThGZ5xaQgc8lc= X-Google-Smtp-Source: ABdhPJxQjws2mloxhrfVwndzh+qyK0VtTyyW1Ebe38OYBVK7LU+s7UXVE4pdXujubm9vT9JX1He1wqHhh6JroodbfYI= X-Received: by 2002:aca:4441:: with SMTP id r62mr10155966oia.153.1602508568842; Mon, 12 Oct 2020 06:16:08 -0700 (PDT) MIME-Version: 1.0 References: <20201008154651.1901126-1-arnd@arndb.de> <20201008154651.1901126-13-arnd@arndb.de> In-Reply-To: <20201008154651.1901126-13-arnd@arndb.de> From: Geert Uytterhoeven Date: Mon, 12 Oct 2020 15:15:57 +0200 Message-ID: Subject: Re: [PATCH 12/13] timekeeping: default GENERIC_CLOCKEVENTS to enabled To: Arnd Bergmann Cc: Linux Kernel Mailing List , Russell King , Tony Luck , Fenghua Yu , Greg Ungerer , Finn Thain , Philip Blundell , Joshua Thompson , Sam Creasey , "James E.J. Bottomley" , Helge Deller , Thomas Gleixner , Daniel Lezcano , John Stultz , Stephen Boyd , Linus Walleij , "linux-ia64@vger.kernel.org" , Parisc List , linux-m68k , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 8, 2020 at 5:48 PM Arnd Bergmann wrote: > Almost all machines use GENERIC_CLOCKEVENTS, so it feels wrong to > require each one to select that symbol manually. > > Instead, enable it whenever CONFIG_LEGACY_TIMER_TICK is disabled as > a simplification. It should be possible to select both > GENERIC_CLOCKEVENTS and LEGACY_TIMER_TICK from an architecture now > and decide at runtime between the two. > > For the clockevents arch-support.txt file, this means that additional > architectures are marked as TODO when they have at least one machine > that still uses LEGACY_TIMER_TICK, rather than being marked 'ok' when > at least one machine has been converted. This means that both m68k and > arm (for riscpc) revert to TODO. > > At this point, we could just always enable CONFIG_GENERIC_CLOCKEVENTS > rather than leaving it off when not needed. I built an m68k > defconfig kernel (using gcc-10.1.0) and found that this would add > around 5.5KB in kernel image size: > > text data bss dec hex filename > 3861936 1092236 196656 5150828 4e986c obj-m68k/vmlinux-no-clockevent > 3866201 1093832 196184 5156217 4ead79 obj-m68k/vmlinux-clockevent > > On Arm (MACH_RPC), that difference appears to be twice as large, > around 11KB on top of an 6MB vmlinux. > > Signed-off-by: Arnd Bergmann Reviewed-by: Geert Uytterhoeven > arch/m68k/Kconfig.cpu | 1 - Acked-by: Geert Uytterhoeven Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds