From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751693AbdBIL7l (ORCPT ); Thu, 9 Feb 2017 06:59:41 -0500 Received: from mail-io0-f193.google.com ([209.85.223.193]:32825 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751613AbdBIL7i (ORCPT ); Thu, 9 Feb 2017 06:59:38 -0500 MIME-Version: 1.0 In-Reply-To: <8dd7db81-fc45-8054-82fa-3b09be455ef7@gmail.com> References: <1481123360-10978-1-git-send-email-geert@linux-m68k.org> <1481123360-10978-2-git-send-email-geert@linux-m68k.org> <8dd7db81-fc45-8054-82fa-3b09be455ef7@gmail.com> From: Geert Uytterhoeven Date: Thu, 9 Feb 2017 12:59:32 +0100 X-Google-Sender-Auth: RFj4mKvUGByxCSOQ3YOx0wy9jxk Message-ID: Subject: Re: [PATCH 01/22] m68k/atari: Modernize printing of kernel messages To: Michael Schmitz Cc: Finn Thain , Greg Ungerer , Sam Creasey , Joshua Thompson , linux-m68k , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michael, On Sat, Dec 10, 2016 at 1:44 AM, Michael Schmitz wrote: > Am 09.12.2016 um 01:22 schrieb Geert Uytterhoeven: >> On Wed, Dec 7, 2016 at 11:36 PM, Finn Thain wrote: >>> On Wed, 7 Dec 2016, Geert Uytterhoeven wrote: >>>> - Convert from printk() to pr_*(), >>>> - Add missing continuations, to fix user-visible breakage, >>>> - Drop useless WARNING prefix, >>>> - Move trailing spaces to start of continuations. >>>> >>>> Fixes: 4bcc595ccd80decb ("printk: reinstate KERN_CONT for printing continuation lines") >>>> Signed-off-by: Geert Uytterhoeven >>>> --- >>>> arch/m68k/atari/atakeyb.c | 14 ++++++------ >>>> arch/m68k/atari/config.c | 56 +++++++++++++++++++++++------------------------ >>>> 2 files changed, 35 insertions(+), 35 deletions(-) >>>> >>>> diff --git a/arch/m68k/atari/atakeyb.c b/arch/m68k/atari/atakeyb.c >>>> index 264db11268039329..37091898adb3d3b5 100644 >>>> --- a/arch/m68k/atari/atakeyb.c >>>> +++ b/arch/m68k/atari/atakeyb.c >>>> @@ -149,7 +149,7 @@ static irqreturn_t atari_keyboard_interrupt(int irq, void *dummy) >>>> if (acia_stat & ACIA_OVRN) { >>>> /* a very fast typist or a slow system, give a warning */ >>>> /* ...happens often if interrupts were disabled for too long */ >>>> - printk(KERN_DEBUG "Keyboard overrun\n"); >>>> + pr_debug("Keyboard overrun\n"); >>>> scancode = acia.key_data; >>>> if (ikbd_self_test) >>>> /* During self test, don't do resyncing, just process the code */ >>> >>> This is not equivalent (unless there is a DEBUG macro definition hinding >>> in a header file somewhere). Since the changelog doesn't mention >>> suppressing any output, perhaps you were deceived by the questionable API, >>> as I have been in the past (see 16b9d870a0 and d61c5427f6). >> >> This is an actual message people want to see in the kernel log, even > > No, it's not something people want to see - clutters up the screen, and > causes even more interrupt hogging disk IO from syslogd so exacerbates > the problem on slow systems. > > But Finn is right in that output is now suppressed instead of given a > particular log level. IMO stating that the message will now only be > generated when the kernel has been compiled for debugging would be > perfectly fine. Thanks, will update the commit message. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds