From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Linux-Arch <linux-arch@vger.kernel.org>,
Linux MIPS Mailing List <linux-mips@linux-mips.org>,
"moderated list:PANASONIC MN10300..."
<linux-am33-list@redhat.com>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
linux-c6x-dev@linux-c6x.org,
Parisc List <linux-parisc@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
"adi-buildroot-devel@lists.sourceforge.net"
<adi-buildroot-devel@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-m68k <linux-m68k@vger.kernel.org>,
alpha <linux-alpha@vger.kernel.org>,
"the arch/x86 maintainers" <x86@kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 3/3] IRQ: Print "unexpected IRQ" messages consistently across architectures
Date: Mon, 13 Jul 2015 09:14:42 +0200 [thread overview]
Message-ID: <CAMuHMdWW3uHLm=rwQ8cmhxGff8vwFDx7_-eSmiy3dndpDKk35Q@mail.gmail.com> (raw)
In-Reply-To: <20150712220211.7166.42035.stgit@bhelgaas-glaptop2.roam.corp.google.com>
On Mon, Jul 13, 2015 at 12:02 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> Many architectures use a variant of "unexpected IRQ trap at vector %x" to
> log unexpected IRQs. This is confusing because (a) it prints the Linux IRQ
> number, but "vector" more often refers to a CPU vector number, and (b) it
> prints the IRQ number in hex with no base indication, while Linux IRQ
> numbers are usually printed in decimal.
>
> Print the same text ("unexpected IRQ %d") across all architectures.
>
> No functional change other than the output text.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
Thanks!
> arch/m68k/include/asm/hardirq.h | 2 +-
For m68k:
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
And it looks like m68k can switch to the asm-generic version afterwards...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2015-07-13 7:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-12 22:01 [PATCH 0/3] IRQ trivial clarifications Bjorn Helgaas
2015-07-12 22:01 ` [PATCH 1/3] x86, irq: Rename VECTOR_UNDEFINED and VECTOR_RETRIGGERED to IRQ_* Bjorn Helgaas
2015-07-17 14:06 ` Thomas Gleixner
2015-07-17 17:50 ` Bjorn Helgaas
2015-07-12 22:02 ` [PATCH 2/3] x86, irq: Clarify "No irq handler" message Bjorn Helgaas
2015-07-12 22:02 ` [PATCH 3/3] IRQ: Print "unexpected IRQ" messages consistently across architectures Bjorn Helgaas
2015-07-13 3:23 ` [3/3] " Michael Ellerman
2015-07-13 18:35 ` Bjorn Helgaas
2015-07-16 4:12 ` Michael Ellerman
2015-07-13 7:14 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdWW3uHLm=rwQ8cmhxGff8vwFDx7_-eSmiy3dndpDKk35Q@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=bhelgaas@google.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-am33-list@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-c6x-dev@linux-c6x.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).