From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Collabora Kernel ML <kernel@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
Benson Leung <bleung@chromium.org>,
Dmitry Torokhov <dtor@chromium.org>,
fabien.lahoudere@collabora.com,
Guillaume Tucker <guillaume.tucker@collabora.com>,
"H. Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>,
"the arch/x86 maintainers" <x86@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
"Ahmed S. Darwish" <darwish.07@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Alexey Brodkin <alexey.brodkin@synopsys.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ard Biesheuvel <ardb@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 1/2] x86_64_defconfig: Normalize x86_64 defconfig
Date: Wed, 4 Dec 2019 09:04:49 +0100 [thread overview]
Message-ID: <CAMuHMdWbS+AD4me1fT4yuzDGTp4piubTcQ_3UHP1nrbZ3YFyow@mail.gmail.com> (raw)
In-Reply-To: <CAJKOXPfzYSJdVg_j7MPP14WOve0cJpF+NV2FWWhjGbUEwVWavw@mail.gmail.com>
Hi Krzysztof,
On Wed, Dec 4, 2019 at 2:15 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On Tue, 3 Dec 2019 at 18:01, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Tue, Dec 3, 2019 at 10:26 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > On Tue, 3 Dec 2019 at 17:05, Enric Balletbo i Serra
> > > <enric.balletbo@collabora.com> wrote:
> > > > On 3/12/19 3:15, Krzysztof Kozlowski wrote:
> > > > > On Tue, 3 Dec 2019 at 05:18, Enric Balletbo i Serra
> > > > > <enric.balletbo@collabora.com> wrote:
> > > > >>
> > > > >> make savedefconfig result in some difference, lets normalize the
> > > > >> defconfig
> > > > >>
> > > > >
> > > > > No, for two reasons:
> > > > > 1. If running savedefconfig at all, split reordering items from
> > > > > removal of non needed options. This way we can see exactly what is
> > > > > being removed. This patch moves things around so it is not possible to
> > > > > understand what exactly you're doing here...
> > > >
> > > > Ok, makes sense, I can do it, but if you don't really care of having the
> > > > defconfig sync with the savedefconfig output for the below reasons or others,
> > > > that's fine with me.
> > > >
> > > > The reason I send the patch is because I think that, at least on some arm
> > > > defconfigs, they try to have the defconfig sync with the savedefconfig output,
> > > > the idea is to try to make patching the file easier, but I know this is usually
> > > > a pain.
> > >
> > > Till I saw DEBUG_FS removal and Steven's answer, I was all in in such
> > > patches from time to time. However now I think it's risky and instead
> > > manual cleanup of non-visible symbols is better.
> >
> > IMHO, it's the maintainer's responsibility to refresh the defconfig(s)
> > regularly, from known good config(s).
> >
> > I.e. you start from a known good .config, run "make oldconfig", verify
> > the changes by comparing the .config before/after, and run "make
> > savedefconfig" afterwards.
> >
> > You do not run blindly "make <my>_defconfig && make savedefconfig", as
> > that means you'll miss out on new options you may want, and will loose
> > old options that are no longer selected by other options.
>
> Instead of keeping this known good config somewhere outside it should
> be just equal to defconfig. There is no point to trim it with
> savedefconfig and then later experience missing options (because some
> option was a dependency but now is not). Instead, all visible options
> (possible to select) should be explicitly defined by defconfig to
> avoid what happened with DEBUG_FS.
While I agree that would fix the issue, it would revert to the situation
before we had savedefconfig. Hence it would cause much more churn to the
checked-in defconfig files, which is the reason why savedefconfig was
introduced in the first place....
> I assume here that when removing
> non-visible options from dependency, all defconfigs would be updated.
I'm afraid that part will never happen...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2019-12-04 8:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 21:18 [PATCH 0/2] Standard x86_64 defconfig for KernelCI or Chromebooks Enric Balletbo i Serra
2019-12-02 21:18 ` [PATCH 1/2] x86_64_defconfig: Normalize x86_64 defconfig Enric Balletbo i Serra
2019-12-03 2:15 ` Krzysztof Kozlowski
2019-12-03 9:05 ` Enric Balletbo i Serra
2019-12-03 9:26 ` Krzysztof Kozlowski
2019-12-03 10:00 ` Geert Uytterhoeven
2019-12-04 1:15 ` Krzysztof Kozlowski
2019-12-04 1:22 ` Steven Rostedt
2019-12-04 8:04 ` Geert Uytterhoeven [this message]
2019-12-02 21:18 ` [PATCH 2/2] x86_64_defconfig: Enable support for Chromebooks devices Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdWbS+AD4me1fT4yuzDGTp4piubTcQ_3UHP1nrbZ3YFyow@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=akpm@linux-foundation.org \
--cc=alexey.brodkin@synopsys.com \
--cc=ardb@kernel.org \
--cc=bleung@chromium.org \
--cc=bp@alien8.de \
--cc=darwish.07@gmail.com \
--cc=dtor@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=fabien.lahoudere@collabora.com \
--cc=geert+renesas@glider.be \
--cc=groeck@chromium.org \
--cc=guillaume.tucker@collabora.com \
--cc=hpa@zytor.com \
--cc=kernel@collabora.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).