From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Rodrigo Rolim Mendes de Alencar <455.rodrigo.alencar@gmail.com>
Cc: Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
alencar.fmce@imbel.gov.br
Subject: Re: [PATCH 2/3] video: fbdev: ssd1307fb: Support to pixel inversion
Date: Wed, 13 May 2020 09:09:24 +0200 [thread overview]
Message-ID: <CAMuHMdWiNhpEbXbTcYVJ2gP5X++gwmP5Wb2n9VYchTBFyi07GA@mail.gmail.com> (raw)
In-Reply-To: <1589316769-13277-2-git-send-email-alencar.fmce@imbel.gov.br>
Hi Rodrigo,
On Tue, May 12, 2020 at 10:53 PM Rodrigo Rolim Mendes de Alencar
<455.rodrigo.alencar@gmail.com> wrote:
> Pixel inversion in hardware is performed by issuing the
> command 0xa7. This patch adds a boolean property to control
> color inversion.
>
> Signed-off-by: Rodrigo Alencar <455.rodrigo.alencar@gmail.com>
Thanks for your patch!
> --- a/Documentation/devicetree/bindings/display/ssd1307fb.txt
> +++ b/Documentation/devicetree/bindings/display/ssd1307fb.txt
> @@ -22,6 +22,7 @@ Optional properties:
> - solomon,com-seq: Display uses sequential COM pin configuration
> - solomon,com-lrremap: Display uses left-right COM pin remap
> - solomon,com-invdir: Display uses inverted COM pin scan direction
> + - solomon,color-inv: Set Inverse display mode (invert pixel color)
Isn't that software configuration instead of hard description?
DT describes the hardware, not software configuration, so this may not
belong here?
> - solomon,com-offset: Number of the COM pin wired to the first display line
> - solomon,col-offset: Offset of columns (SEG) that the screen is mapped to.
> - solomon,prechargep1: Length of deselect period (phase 1) in clock cycles.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2020-05-13 7:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 20:52 [PATCH 1/3] video: fbdev: ssd1307fb: Added support to Column offset Rodrigo Rolim Mendes de Alencar
2020-05-12 20:52 ` [PATCH 2/3] video: fbdev: ssd1307fb: Support to pixel inversion Rodrigo Rolim Mendes de Alencar
2020-05-13 7:09 ` Geert Uytterhoeven [this message]
2020-05-12 20:52 ` [PATCH 3/3] video: fbdev: ssd1307fb: Switch to atomic PWM API Rodrigo Rolim Mendes de Alencar
2020-05-12 20:59 ` [PATCH 1/3] video: fbdev: ssd1307fb: Added support to Column offset Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdWiNhpEbXbTcYVJ2gP5X++gwmP5Wb2n9VYchTBFyi07GA@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=455.rodrigo.alencar@gmail.com \
--cc=alencar.fmce@imbel.gov.br \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).