From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751895AbdHXNcs (ORCPT ); Thu, 24 Aug 2017 09:32:48 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:34881 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751123AbdHXNcF (ORCPT ); Thu, 24 Aug 2017 09:32:05 -0400 MIME-Version: 1.0 In-Reply-To: <20170823170805.GL491396@devbig577.frc2.facebook.com> References: <20170731153806.GC447614@devbig577.frc2.facebook.com> <20170807170659.GB537256@devbig577.frc2.facebook.com> <20170823142421.GK491396@devbig577.frc2.facebook.com> <20170823170805.GL491396@devbig577.frc2.facebook.com> From: Geert Uytterhoeven Date: Thu, 24 Aug 2017 15:32:04 +0200 X-Google-Sender-Auth: 8YNWa52wNtBJ0lnHrV3gj9CLxFs Message-ID: Subject: Re: [GIT PULL] workqueue fixes for v4.13-rc3 To: Tejun Heo Cc: Linus Torvalds , "linux-kernel@vger.kernel.org" , Lai Jiangshan , Michael Bringmann Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tejun, On Wed, Aug 23, 2017 at 7:08 PM, Tejun Heo wrote: > On Wed, Aug 23, 2017 at 04:47:41PM +0200, Geert Uytterhoeven wrote: >> Some code is mixing up multiple memory nodes with multiple cpu nodes. >> M68k uses DISCONTIGMEM, but not NUMA (no SMP): >> >> config NEED_MULTIPLE_NODES >> def_bool y >> depends on DISCONTIGMEM || NUMA >> >> The (virtual) Atari has 2 memory nodes: >> - node0: start 0x00000000 size 0x00e00000 >> - node1: start 0x01000000 size 0x10000000 >> Both are tied to the same (single) CPU node, of course. > > Ah, okay, so it has multiple nodes but not NUMA. The generic numa > topology code assumes that there's only one node if !NUMA and reports > all online cpus regardless of the node number, which makes the same > CPUs to be reported for all nodes on the system. I think something > like the following (completely untested) should work. Thank you, that got rid of the warning. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds