From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 101ABC433DF for ; Mon, 12 Oct 2020 13:15:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C77D520838 for ; Mon, 12 Oct 2020 13:15:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388782AbgJLNPl (ORCPT ); Mon, 12 Oct 2020 09:15:41 -0400 Received: from mail-oo1-f66.google.com ([209.85.161.66]:34693 "EHLO mail-oo1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388767AbgJLNPh (ORCPT ); Mon, 12 Oct 2020 09:15:37 -0400 Received: by mail-oo1-f66.google.com with SMTP id o20so4054095ook.1; Mon, 12 Oct 2020 06:15:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OFhRs7TjS820R6Lv4nnFfwi1wzFa7myuHvQUHpv2Z9o=; b=GRHsh95vW2HKE1Tw7PYY4DeAVowMEkIJNAQrU7wVr0cWsc/gYkMfDT2y0zVKrX3ns3 LK6QI3NbFVzKwEJtPxmzqAysl2M9tUo80BQqdDLzIkw4cvwtLRTYS34xVZdGjBMSpX1v AwE7h4TCoWBf8r+Xp3NaO1U7SYj8i3n72wTK9+h8CpzXFqlVoWiE1T4bGc4PamfYMUyA SFOHq2gI6anxsTEUfGjFm9z4VJKeIX8MYTgqtz/wSOdlaCfhmUaFhREz0DsSiKY3iCeL LQ1kIbNfEX8paR/eG9AdUrAkTaTdQaW/k+weCFgKnePZK4xwUbtFOdozO7y/Bbf6Y7MQ 1LvA== X-Gm-Message-State: AOAM5316SSz6Dczi2NcqXzwd+5OyVNleqsTEhOBDOrPA7W4GxIuzWiXi n/RIkwznLLeX2RhsYxSEpgs+EcozHG08muNLiic= X-Google-Smtp-Source: ABdhPJwH87hW/Pgij7RCQUnzcFXjl6OK87/RDvKI1ooIz6IBNHxF4/GrZMi+obXHOEc8W7DIRvqP891GQZlhJ9GHy5c= X-Received: by 2002:a4a:5d84:: with SMTP id w126mr18415022ooa.1.1602508536062; Mon, 12 Oct 2020 06:15:36 -0700 (PDT) MIME-Version: 1.0 References: <20201008154651.1901126-1-arnd@arndb.de> <20201008154651.1901126-9-arnd@arndb.de> In-Reply-To: <20201008154651.1901126-9-arnd@arndb.de> From: Geert Uytterhoeven Date: Mon, 12 Oct 2020 15:15:25 +0200 Message-ID: Subject: Re: [PATCH 08/13] m68k: m68328: use legacy_timer_tick() To: Arnd Bergmann Cc: Linux Kernel Mailing List , Russell King , Tony Luck , Fenghua Yu , Greg Ungerer , Finn Thain , Philip Blundell , Joshua Thompson , Sam Creasey , "James E.J. Bottomley" , Helge Deller , Thomas Gleixner , Daniel Lezcano , John Stultz , Stephen Boyd , Linus Walleij , "linux-ia64@vger.kernel.org" , Parisc List , linux-m68k , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On Thu, Oct 8, 2020 at 5:48 PM Arnd Bergmann wrote: > A couple of machines share the m68328 timer code that > is based on calling timer_interrupt(). Change these > to the new and slightly more generic legacy_timer_tick() > helper. > > Signed-off-by: Arnd Bergmann Thanks for your patch! > --- a/arch/m68k/Kconfig.machine > +++ b/arch/m68k/Kconfig.machine > @@ -146,6 +146,7 @@ config PILOT > config PILOT3 > bool "Pilot 1000/5000, PalmPilot Personal/Pro, or PalmIII support" > depends on M68328 > + select LEGACY_TIMER_TICK > select PILOT > help > Support for the Palm Pilot 1000/5000, Personal/Pro and PalmIII. > @@ -159,18 +160,21 @@ config XCOPILOT_BUGS > config UCSIMM > bool "uCsimm module support" > depends on M68EZ328 > + select LEGACY_TIMER_TICK > help > Support for the Arcturus Networks uCsimm module. > > config UCDIMM > bool "uDsimm module support" > depends on M68VZ328 > + select LEGACY_TIMER_TICK > help > Support for the Arcturus Networks uDsimm module. > > config DRAGEN2 > bool "DragenEngine II board support" > depends on M68VZ328 > + select LEGACY_TIMER_TICK > help > Support for the DragenEngine II board. Given this feature is SoC-specific, not platform-specific, perhaps it makes sense to move the selects to the M68{,EZ,VZ}328 symbols? Regardless: Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds