From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933540AbcIFMY0 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 6 Sep 2016 08:24:26 -0400
Received: from mail-oi0-f67.google.com ([209.85.218.67]:35051 "EHLO
        mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753617AbcIFMYW (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 6 Sep 2016 08:24:22 -0400
MIME-Version: 1.0
In-Reply-To: <SIXPR06MB09064A12322A3E45026399B1A8F90@SIXPR06MB0906.apcprd06.prod.outlook.com>
References: <SIXPR06MB09069C18D1F37BE5DB1284B3A8E40@SIXPR06MB0906.apcprd06.prod.outlook.com>
 <CAMuHMdXjywuuQG8LLMddOTjCpC5Ady3hVWvm_SM_AcpFScwWDw@mail.gmail.com> <SIXPR06MB09064A12322A3E45026399B1A8F90@SIXPR06MB0906.apcprd06.prod.outlook.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Tue, 6 Sep 2016 14:24:20 +0200
X-Google-Sender-Auth: Vvqv0Ubz-jspYVl4_i27EzgGi9M
Message-ID: <CAMuHMdWujzjS9pDett3BT+xboS6DnhWmyF_hRQMJ2QUOJfPnjw@mail.gmail.com>
Subject: Re: [PATCH 2/5 v2] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver
To: Khiem Nguyen <khiem.nguyen.xt@renesas.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
        Wolfram Sang <wsa@the-dreams.de>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Magnus Damm <damm+renesas@opensource.se>,
        Zhang Rui <rui.zhang@intel.com>,
        Eduardo Valentin <edubezval@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Thao Phuong Le. Nguyen" <thao.nguyen.yb@rvc.renesas.com>,
        Hien Dang <hien.dang.eb@renesas.com>,
        Toru Oishi <toru.oishi.zj@renesas.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Khiem,

On Tue, Sep 6, 2016 at 2:19 PM, Khiem Nguyen
<khiem.nguyen.xt@renesas.com> wrote:
>> > +static int rcar_gen3_thermal_probe(struct platform_device *pdev) {
>>
>> > +       priv->id = of_alias_get_id(dev->of_node, "tsc");
>> > +       if (priv->id < 0) {
>> > +               dev_err(dev, "Failed to get alias id (%d)\n", priv->id);
>> > +               ret = priv->id;
>> > +               goto error_unregister;
>> > +       }
>>
>> In v1, Morimoto-san wondered whether the alias is really needed, but you haven't
>> addressed his question.
>>
>> While aliases can be useful in DT source files, using aliases like this imposes
>> hardcoded instance numbers, which is something we try to avoid these days.
>> Also, this puts a hard requirement on the presence of the alias in DT, which should
>> be documented in the DT bindings.
>
> OK.
> I prefer updating DT binding to describe alias.
>
> There is requirement about coefficient to calculate temperature,
> and the coefficient value (fixed value) is different among thermal sensors.

>>From DT, you can still refer to a specific instance using a phandle to a label.
You do not need aliases for that.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds