From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list:TI ETHERNET SWITCH DRIVER (CPSW)"
<linux-omap@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Rob Herring <robh@kernel.org>,
Simon Horman <horms+renesas@verge.net.au>,
Suman Anna <s-anna@ti.com>
Subject: Re: [PATCH 1/3] dt-bindings: bus: simple-pm-bus: Make clocks and power-domains optional
Date: Thu, 7 Oct 2021 15:26:44 +0200 [thread overview]
Message-ID: <CAMuHMdX3XBA25sUMF2SpfbH7XX5-UpPFj-0nHuwDOv49YWQn+A@mail.gmail.com> (raw)
In-Reply-To: <20211007124858.44011-2-tony@atomide.com>
Hi Tony,
Thanks for your patch!
On Thu, Oct 7, 2021 at 2:49 PM Tony Lindgren <tony@atomide.com> wrote:
> Clocks and power domains are not required by the simple-pm-bus driver.
> There are buses with read-only registers for clocks and power domains
> that are always on.
The presence of clocks or power-domains properties is the only
distinguishing factor between simple-pm-bus and simple-bus, from a
DT point of view. So if there has to be a distinguishment, the
properties should be required
If you don't have clocks and power-domains, you should use simple-bus.
> Even without clocks and power domains configured, simple-pm-bus is still
> different from simple-bus as simple-pm-bus enables runtime PM for the bus
> driver.
Which you need to have working Runtime PM for child devices, right? ;-)
This is not specific to DT, but to Linux.
One more reason to let Linux treat simple-pm-bus and simple-bus exactly
the same. Linux handles the clocks and power-domains (if present)
transparently anyway, through PM Domains
> Let's update the binding accordingly as this remove the related warnings
> for dt_binding_check for omaps.
>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Simon Horman <horms+renesas@verge.net.au>
> Cc: Suman Anna <s-anna@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> --- a/Documentation/devicetree/bindings/bus/simple-pm-bus.yaml
> +++ b/Documentation/devicetree/bindings/bus/simple-pm-bus.yaml
> @@ -13,10 +13,9 @@ description: |
> A Simple Power-Managed Bus is a transparent bus that doesn't need a real
> driver, as it's typically initialized by the boot loader.
>
> - However, its bus controller is part of a PM domain, or under the control
> - of a functional clock. Hence, the bus controller's PM domain and/or
> - clock must be enabled for child devices connected to the bus (either
> - on-SoC or externally) to function.
> + However, its bus controller is typically part of a PM domain, or under
> + the control of a functional clock. Without PM domain or functional clock,
> + it still enables runtime PM for the bus driver unlike "simple-bus".
>
> While "simple-pm-bus" follows the "simple-bus" set of properties, as
> specified in the Devicetree Specification, it is not an extension of
> @@ -43,10 +42,10 @@ properties:
>
> clocks: true
> # Functional clocks
> - # Required if power-domains is absent, optional otherwise
> + # Typically used if power-domains is absent
>
> power-domains:
> - # Required if clocks is absent, optional otherwise
> + # Typically used if clocks is absent
> minItems: 1
>
> required:
> @@ -55,12 +54,6 @@ required:
> - '#size-cells'
> - ranges
>
> -anyOf:
> - - required:
> - - clocks
> - - required:
> - - power-domains
> -
> additionalProperties: true
>
> examples:
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-10-07 13:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 12:48 [PATCH 0/3] Updates for simple-pm-bus and ti-sysc bindings Tony Lindgren
2021-10-07 12:48 ` [PATCH 1/3] dt-bindings: bus: simple-pm-bus: Make clocks and power-domains optional Tony Lindgren
2021-10-07 13:26 ` Geert Uytterhoeven [this message]
2021-10-07 17:24 ` Tony Lindgren
2021-10-07 17:57 ` Geert Uytterhoeven
2021-10-07 18:17 ` Tony Lindgren
2021-10-07 12:48 ` [PATCH 2/3] dt-bindings: bus: simple-pm-bus: Add more matches for node name Tony Lindgren
2021-10-07 12:48 ` [PATCH 3/3] dt-bindings: bus: ti-sysc: Update to use yaml binding Tony Lindgren
2021-10-08 2:46 ` Rob Herring
2021-10-08 20:39 ` Rob Herring
2021-10-11 5:50 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdX3XBA25sUMF2SpfbH7XX5-UpPFj-0nHuwDOv49YWQn+A@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=s-anna@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).