From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>,
Finn Thain <fthain@telegraphics.com.au>,
linux-m68k <linux-m68k@lists.linux-m68k.org>
Subject: Re: [PATCH 09/12] nubus: use for_each_if
Date: Tue, 17 Jul 2018 17:26:21 +0200 [thread overview]
Message-ID: <CAMuHMdX3x_anEXtYyL4BnBoOqRew3MDFSAr6CrRaru0BLpcnZQ@mail.gmail.com> (raw)
In-Reply-To: <20180709083650.23549-9-daniel.vetter@ffwll.ch>
Hi Daniel,
On Mon, Jul 9, 2018 at 10:44 AM Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Avoids the inverted check compared to the open-coded version.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Finn Thain <fthain@telegraphics.com.au>
> Cc: linux-m68k@lists.linux-m68k.org
Thanks for your patch!
> --- a/include/linux/nubus.h
> +++ b/include/linux/nubus.h
> @@ -127,7 +127,7 @@ struct nubus_rsrc *nubus_next_rsrc_or_null(struct nubus_rsrc *from);
> for (f = nubus_first_rsrc_or_null(); f; f = nubus_next_rsrc_or_null(f))
>
> #define for_each_board_func_rsrc(b, f) \
> - for_each_func_rsrc(f) if (f->board != b) {} else
> + for_each_func_rsrc(f) for_each_if (f->board == b)
drivers/net/ethernet/8390/mac8390.c: In function ‘mac8390_device_probe’:
drivers/net/ethernet/8390/mac8390.c:402: error: implicit declaration
of function ‘for_each_if’
drivers/net/ethernet/8390/mac8390.c:402: error: expected ‘;’ before ‘{’ token
Apparently this depends on patch [01/12], which wasn't CCed to
linux-m68k@lists.linux-m68k.org?
Please don't split CCs if all patches in the a series are not independent.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2018-07-17 15:26 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 8:36 [PATCH 01/12] kernel.h: Add for_each_if() Daniel Vetter
2018-07-09 8:36 ` [PATCH 02/12] blk: use for_each_if Daniel Vetter
2018-07-11 16:40 ` Tejun Heo
2018-07-11 16:45 ` Tejun Heo
2018-07-11 18:30 ` Jens Axboe
2018-07-11 18:50 ` Daniel Vetter
2018-07-11 19:31 ` Jens Axboe
2018-07-11 20:06 ` Tejun Heo
2018-07-11 21:08 ` Daniel Vetter
2018-07-11 21:13 ` Jens Axboe
2018-07-12 6:41 ` Daniel Vetter
2018-07-12 6:45 ` Joe Perches
2018-07-12 13:54 ` Jens Axboe
2018-07-12 15:32 ` Joe Perches
2018-07-13 9:28 ` Vlastimil Babka
2018-07-09 8:36 ` [PATCH 03/12] cgroup: " Daniel Vetter
2018-07-11 16:46 ` Tejun Heo
2018-07-09 8:36 ` [PATCH 04/12] cpufreq: " Daniel Vetter
2018-07-09 9:28 ` Eric Engestrom
2018-07-09 16:11 ` [PATCH] " Daniel Vetter
2018-07-09 21:36 ` Rafael J. Wysocki
2018-07-09 8:36 ` [PATCH 05/12] dmar: Use for_each_If Daniel Vetter
2018-07-20 12:50 ` Joerg Roedel
2018-07-09 8:36 ` [PATCH 06/12] mm: use for_each_if Daniel Vetter
2018-07-09 18:00 ` Pavel Tatashin
2018-07-09 8:36 ` [PATCH 07/12] ide: " Daniel Vetter
2018-07-09 8:36 ` [PATCH 08/12] netdev: " Daniel Vetter
2018-07-09 8:36 ` [PATCH 09/12] nubus: " Daniel Vetter
2018-07-09 10:17 ` Finn Thain
2018-07-17 15:26 ` Geert Uytterhoeven [this message]
2018-07-09 8:36 ` [PATCH 10/12] pci: " Daniel Vetter
2018-07-09 22:48 ` Bjorn Helgaas
2018-07-09 8:36 ` [PATCH 11/12] sched: use for_each_if in topology.h Daniel Vetter
2018-07-09 10:36 ` Peter Zijlstra
2018-07-09 15:00 ` Daniel Vetter
2018-07-09 15:12 ` Peter Zijlstra
2018-07-09 15:52 ` Daniel Vetter
2018-07-09 16:03 ` Peter Zijlstra
2018-07-09 16:06 ` Daniel Vetter
2018-07-09 16:12 ` Mark Rutland
2018-07-09 17:55 ` [Intel-gfx] " Daniel Vetter
2018-07-11 16:51 ` Mark Rutland
2018-07-09 16:30 ` Peter Zijlstra
2018-07-09 8:36 ` [PATCH 12/12] usb: use for_each_if Daniel Vetter
2018-07-09 11:50 ` [PATCH 01/12] kernel.h: Add for_each_if() Andy Shevchenko
2018-07-09 16:25 ` [PATCH] " Daniel Vetter
2018-07-09 18:30 ` Andy Shevchenko
2018-07-09 23:30 ` Andrew Morton
2018-07-10 7:53 ` Daniel Vetter
2018-07-10 10:32 ` NeilBrown
2018-07-11 11:51 ` Daniel Vetter
2018-07-11 23:05 ` Andrew Morton
2018-07-12 6:39 ` Daniel Vetter
2018-07-13 23:37 ` NeilBrown
2018-07-13 23:42 ` Randy Dunlap
2018-07-16 8:11 ` Andy Shevchenko
2018-07-16 15:41 ` Randy Dunlap
2018-07-16 22:16 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdX3x_anEXtYyL4BnBoOqRew3MDFSAr6CrRaru0BLpcnZQ@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fthain@telegraphics.com.au \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).