linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "H. Nikolaus Schaller" <hns@goldelico.com>,
	"Paul Cercueil" <paul@crapouillou.net>,
	"Paul Boddie" <paul@boddie.org.uk>,
	"Alex Smith" <alex.smith@imgtec.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Ralf Baechle" <ralf@linux-mips.org>,
	"Paul Burton" <paulburton@kernel.org>,
	"James Hogan" <jhogan@kernel.org>,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"David S. Miller" <davem@davemloft.net>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Andi Kleen" <ak@linux.intel.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Petr Štetiar" <ynezz@true.cz>,
	"Richard Fontana" <rfontana@redhat.com>,
	"Allison Randal" <allison@lohutok.net>,
	"Stephen Boyd" <swboyd@chromium.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	linux-mips@vger.kernel.org,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"DRI Development" <dri-devel@lists.freedesktop.org>,
	"Linux I2C" <linux-i2c@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	letux-kernel@openphoenux.org, kernel@pyra-handheld.com
Subject: Re: [PATCH 03/14] net: davicom: dm9000: allow to pass MAC address through mac_addr module parameter
Date: Wed, 12 Feb 2020 09:07:52 +0100	[thread overview]
Message-ID: <CAMuHMdX6f+aGZjQSQqVjT=npojq5xH2k2Js8qxG5=n26Z4uFBw@mail.gmail.com> (raw)
In-Reply-To: <20200211222506.GP19213@lunn.ch>

On Tue, Feb 11, 2020 at 11:25 PM Andrew Lunn <andrew@lunn.ch> wrote:
> On Tue, Feb 11, 2020 at 10:41:20PM +0100, H. Nikolaus Schaller wrote:
> > This is needed to give the MIPS Ingenic CI20 board a stable MAC address
> > which can be optionally provided by vendor U-Boot.
> >
> > For get_mac_addr() we use an adapted copy of from ksz884x.c which
> > has very similar functionality.
> >
> > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>
> Hi Nikolaus
>
> Please split these patches by subsystem. So this one patch needs to go
> via netdev.
>
> > +static char *mac_addr = ":";
> > +module_param(mac_addr, charp, 0);
> > +MODULE_PARM_DESC(mac_addr, "MAC address");
>
> Module parameters are not liked.
>
> Can it be passed via device tree? The driver already has code to get
> it out of the device tree.

Yep, typically U-Boot adds an appropriate "local-mac-address" property to the
network device's device node, based on the "ethernet0" alias.

However, the real clue here may be "vendor U-Boot", i.e. no support for the
above?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2020-02-12  8:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11 21:41 [PATCH 00/14] MIPS: Fixes and improvements for CI20 board (JZ4780) H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 01/14] i2c: jz4780: suppress txabrt reports for i2cdetect H. Nikolaus Schaller
2020-02-12  9:46   ` i2c: jz4780: silence log flood on txabrt Wolfram Sang
2020-02-12 14:46     ` H. Nikolaus Schaller
2020-02-12 14:53       ` Wolfram Sang
2020-02-12 14:59         ` H. Nikolaus Schaller
2020-02-13  9:10     ` Wolfram Sang
2020-02-11 21:41 ` [PATCH 02/14] drm: ingenic-drm: add MODULE_DEVICE_TABLE H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 03/14] net: davicom: dm9000: allow to pass MAC address through mac_addr module parameter H. Nikolaus Schaller
2020-02-11 22:25   ` Andrew Lunn
2020-02-12  8:07     ` Geert Uytterhoeven [this message]
2020-02-12  8:13       ` H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 04/14] MIPS: DTS: jz4780: fix #includes for irq.h and gpio.h H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 05/14] MIPS: CI20: defconfig: configure for supporting modules H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 06/14] MIPS: CI20: defconfig: compile leds-gpio driver into the kernel and configure for LED triggers H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 07/14] MIPS: DTS: CI20: fix PMU definitions for ACT8600 H. Nikolaus Schaller
2020-02-11 21:48   ` [Letux-kernel] " Andreas Kemnade
2020-02-11 21:41 ` [PATCH 08/14] MIPS: CI20: defconfig: configure CONFIG_REGULATOR_ACT8865 for PMU H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 09/14] MIPS: DTS: CI20: give eth0_power a defined voltage H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 10/14] MIPS: DTS: CI20: add DT node for IR sensor H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 11/14] MIPS: CI20: defconfig: compile gpio-ir driver H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 12/14] MIPS: DTS: CI20: add DT node for SW1 as Enter button H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 13/14] MIPS: CI20: defconfig: configure for CONFIG_KEYBOARD_GPIO=m H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 14/14] MIPS: DTS: CI20: fix interrupt for pcf8563 RTC H. Nikolaus Schaller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdX6f+aGZjQSQqVjT=npojq5xH2k2Js8qxG5=n26Z4uFBw@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=airlied@linux.ie \
    --cc=ak@linux.intel.com \
    --cc=alex.smith@imgtec.com \
    --cc=allison@lohutok.net \
    --cc=andrew@lunn.ch \
    --cc=daniel@ffwll.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert+renesas@glider.be \
    --cc=hns@goldelico.com \
    --cc=jhogan@kernel.org \
    --cc=kernel@pyra-handheld.com \
    --cc=krzk@kernel.org \
    --cc=letux-kernel@openphoenux.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=paul@boddie.org.uk \
    --cc=paul@crapouillou.net \
    --cc=paulburton@kernel.org \
    --cc=ralf@linux-mips.org \
    --cc=rfontana@redhat.com \
    --cc=robh+dt@kernel.org \
    --cc=swboyd@chromium.org \
    --cc=ynezz@true.cz \
    --subject='Re: [PATCH 03/14] net: davicom: dm9000: allow to pass MAC address through mac_addr module parameter' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).