From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754081Ab3AMJnB (ORCPT ); Sun, 13 Jan 2013 04:43:01 -0500 Received: from mail-vb0-f45.google.com ([209.85.212.45]:39152 "EHLO mail-vb0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753882Ab3AMJm7 (ORCPT ); Sun, 13 Jan 2013 04:42:59 -0500 MIME-Version: 1.0 In-Reply-To: <20121216214800.3ad603b4@endymion.delvare> References: <20120906134830.52cbdfec@endymion.delvare> <20121216214800.3ad603b4@endymion.delvare> Date: Sun, 13 Jan 2013 10:42:56 +0100 X-Google-Sender-Auth: uSENcsSkzHN-ufVaUZt0d7jJrO8 Message-ID: Subject: Re: [PATCH] swim: Add missing spinlock init From: Geert Uytterhoeven To: Jean Delvare Cc: LKML , Finn Thain , "Linux/m68k" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jean, On Sun, Dec 16, 2012 at 9:48 PM, Jean Delvare wrote: > On Thu, 6 Sep 2012 14:03:27 +0200, Geert Uytterhoeven wrote: >> On Thu, Sep 6, 2012 at 1:48 PM, Jean Delvare wrote: >> > It doesn't seem this spinlock was properly initialized. >> >> Quiet possible. There's no SMP on m68k, so all spinlock ops expand to nothing. > > Can we apply my patch still? Or were you suggesting you're fine with > the code as it is? > > Certainly this isn't my area of expertise but I don't quite get the > point of passing a custom lock to blk_init_queue() if locks resolve to > nothing anyway. Thanks, applied and queued for 3.9. >> > Signed-off-by: Jean Delvare >> > Cc: Finn Thain >> > Cc: Geert Uytterhoeven >> > --- >> > I can't even build-test this. >> > >> > drivers/block/swim.c | 1 + >> > 1 file changed, 1 insertion(+) >> > >> > --- linux-3.6-rc4.orig/drivers/block/swim.c 2012-07-21 22:58:29.000000000 +0200 >> > +++ linux-3.6-rc4/drivers/block/swim.c 2012-09-06 13:09:26.713382169 +0200 >> > @@ -845,6 +845,7 @@ static int __devinit swim_floppy_init(st >> > swd->unit[drive].swd = swd; >> > } >> > >> > + spin_lock_init(&swd->lock); >> > swd->queue = blk_init_queue(do_fd_request, &swd->lock); >> > if (!swd->queue) { >> > err = -ENOMEM; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds