From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9FCFC4338F for ; Tue, 24 Aug 2021 15:29:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9045361165 for ; Tue, 24 Aug 2021 15:29:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238299AbhHXPaU (ORCPT ); Tue, 24 Aug 2021 11:30:20 -0400 Received: from mail-ua1-f46.google.com ([209.85.222.46]:37875 "EHLO mail-ua1-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238270AbhHXPaQ (ORCPT ); Tue, 24 Aug 2021 11:30:16 -0400 Received: by mail-ua1-f46.google.com with SMTP id g2so5515794uad.4; Tue, 24 Aug 2021 08:29:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hAXDV2WEgT4Td3amBfmVt3dD/b8AG6VOmssivHHzP80=; b=a8kJKAzUpXpzLAr3teMk3oal54KWfI+2UW9v3mw4X4RGrG4iE1gAdKFssqCp7Unr+X lhsPWKZ1NnGoNbHNqe4oZDL08Mdb3yrRKQmzBq+BW67WCUneGrrjtjY+z0qRLPLdIteJ UymO0hNw32eHrbxb/24HPYdLUMS42m+lMPjSPxGBLypMS5Z+Uwu92mE9nyijU9yyB27D doYXbphHC14KIZVi1kDRWmpfVIy+SgMLZkBVFJEsHuVwszZ/nnmwVNtCLmwY+X5byUqx 2eGLrufwq3wxRbt55Dk4mKR2Q1VxS7lKHp5bQWGhOUVL99sfjyfdpzYCoVydP3A2ShTm 2Yuw== X-Gm-Message-State: AOAM532BZjkU8EjWxJ/wCFKbmxOWev6O2jMqsf4WBeU7RSbVwz0tBdBo cRU08mqPav/dkbuYJwFEaQ0bIW8TJ/M+GDJhqbg= X-Google-Smtp-Source: ABdhPJwznSbMYiskL2sEMZho2ZztXuaeoqRRaFLbXpd7v868+6eys1TK5q2wufzM+tKaq5laBy8v/raMbBKi4X+dqBE= X-Received: by 2002:a9f:35aa:: with SMTP id t39mr134352uad.89.1629818970934; Tue, 24 Aug 2021 08:29:30 -0700 (PDT) MIME-Version: 1.0 References: <20210819154436.117798-1-krzysztof.kozlowski@canonical.com> <20210819154436.117798-4-krzysztof.kozlowski@canonical.com> In-Reply-To: <20210819154436.117798-4-krzysztof.kozlowski@canonical.com> From: Geert Uytterhoeven Date: Tue, 24 Aug 2021 17:29:19 +0200 Message-ID: Subject: Re: [PATCH 4/6] riscv: microchip: mpfs: fix board compatible To: Krzysztof Kozlowski Cc: Ulf Hansson , Rob Herring , Paul Walmsley , Palmer Dabbelt , Albert Ou , Geert Uytterhoeven , Atish Patra , Yash Shah , Masahiro Yamada , Piotr Sroka , Linux MMC List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , linux-riscv Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Thu, Aug 19, 2021 at 5:45 PM Krzysztof Kozlowski wrote: > According to bindings, the compatible must include microchip,mpfs. This > fixes dtbs_check warning: > > arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dt.yaml: /: compatible: ['microchip,mpfs-icicle-kit'] is too short > > Signed-off-by: Krzysztof Kozlowski Thanks for your patch! > --- a/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts > +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts > @@ -10,7 +10,7 @@ > > / { > model = "Microchip PolarFire-SoC Icicle Kit"; > - compatible = "microchip,mpfs-icicle-kit"; > + compatible = "microchip,mpfs-icicle-kit", "microchip,mpfs"; I have the same change in my local tree, but didn't get to submit it yet, so this part is fine ;-) > > chosen { > stdout-path = &serial0; > diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > index b9819570a7d1..cb54da0cc3c4 100644 > --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > @@ -7,7 +7,7 @@ / { > #address-cells = <2>; > #size-cells = <2>; > model = "Microchip MPFS Icicle Kit"; > - compatible = "microchip,mpfs-icicle-kit"; > + compatible = "microchip,mpfs-icicle-kit", "microchip,mpfs"; As this file is the SoC .dtsi, not the board DTS for the full Icicle Kit, the compatible value should be just "microchip,mpfs" (to be augmented by the board DTS). And "model" should be "Microchip PolarFire SoC". Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds