From: Geert Uytterhoeven <geert@linux-m68k.org>
To: linux-m68k <linux-m68k@lists.linux-m68k.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] m68k: Avoid VLA use in mangle_kernel_stack()
Date: Mon, 21 Jan 2019 10:41:36 +0100 [thread overview]
Message-ID: <CAMuHMdXBujvRZcurEP60VNYZPrJcO1-N6RWXhpsTEZ5r14e28g@mail.gmail.com> (raw)
In-Reply-To: <20190107092935.14617-1-geert@linux-m68k.org>
On Mon, Jan 7, 2019 at 10:29 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> With gcc 7.3.0:
>
> arch/m68k/kernel/signal.c: In function ‘mangle_kernel_stack’:
> arch/m68k/kernel/signal.c:654:3: warning: ISO C90 forbids variable length array ‘buf’ [-Wvla]
> unsigned long buf[fsize / 2]; /* yes, twice as much */
> ^~~~~~~~
>
> Replace the variable size by the upper limit, which is 168 bytes.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Thanks, applied and queued for v5.1.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2019-01-21 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 9:29 [PATCH] m68k: Avoid VLA use in mangle_kernel_stack() Geert Uytterhoeven
2019-01-08 13:36 ` Arnd Bergmann
2019-01-21 9:41 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdXBujvRZcurEP60VNYZPrJcO1-N6RWXhpsTEZ5r14e28g@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).