From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Pradeep A. Dalvi" <netdev@pradeepdalvi.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org,
Linux-Next <linux-next@vger.kernel.org>
Subject: Re: [PATCH v5 3/5] netdev: ethernet dev_alloc_skb to netdev_alloc_skb
Date: Tue, 7 Feb 2012 21:04:07 +0100 [thread overview]
Message-ID: <CAMuHMdXFz5zEWUkrJjNvOqkgt-n2uKc3wzD9H5NKKz1LT4BpOw@mail.gmail.com> (raw)
In-Reply-To: <ef62da964e8660dfdf2a25cd643631bb15914ecf.1328445742.git.netdev@pradeepdalvi.com>
On Sun, Feb 5, 2012 at 13:50, Pradeep A. Dalvi <netdev@pradeepdalvi.com> wrote:
> diff --git a/drivers/net/ethernet/natsemi/sonic.c b/drivers/net/ethernet/natsemi/sonic.c
> index 26e25d7..0452e296 100644
> --- a/drivers/net/ethernet/natsemi/sonic.c
> +++ b/drivers/net/ethernet/natsemi/sonic.c
> @@ -51,7 +51,7 @@ static int sonic_open(struct net_device *dev)
> printk("sonic_open: initializing sonic driver.\n");
>
> for (i = 0; i < SONIC_NUM_RRS; i++) {
> - struct sk_buff *skb = dev_alloc_skb(SONIC_RBSIZE + 2);
> + struct sk_buff *skb = netdev_alloc_skb(dev, SONIC_RBSIZE + 2);
> if (skb == NULL) {
> while(i > 0) { /* free any that were allocated successfully */
> i--;
> @@ -422,7 +422,7 @@ static void sonic_rx(struct net_device *dev)
> status = sonic_rda_get(dev, entry, SONIC_RD_STATUS);
> if (status & SONIC_RCR_PRX) {
> /* Malloc up new buffer. */
> - new_skb = dev_alloc_skb(SONIC_RBSIZE + 2);
> + new_skb = netdev_alloc_skb(SONIC_RBSIZE + 2);
drivers/net/ethernet/natsemi/sonic.c:425: error: too few arguments to
function 'netdev_alloc_skb'
cfr. m68k/defconfig http://kisskb.ellerman.id.au/kisskb/buildresult/5583743/
Your search-and-replace script (hmm, you haven't used a script, have
you?) forgot
to add the first "dev" parameter.
> if (new_skb == NULL) {
> printk(KERN_ERR "%s: Memory squeeze, dropping packet.\n", dev->name);
> lp->stats.rx_dropped++;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2012-02-07 20:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-05 12:49 [PATCH v5 1/5] netdev: ethernet dev_alloc_skb to netdev_alloc_skb Pradeep A. Dalvi
2012-02-05 12:50 ` [PATCH v5 2/5] " Pradeep A. Dalvi
2012-02-06 16:49 ` David Miller
2012-02-06 17:40 ` Pradeep A. Dalvi
2012-02-05 12:50 ` [PATCH v5 3/5] " Pradeep A. Dalvi
2012-02-06 16:52 ` David Miller
2012-02-07 20:04 ` Geert Uytterhoeven [this message]
2012-02-07 20:29 ` David Miller
2012-02-05 12:51 ` [PATCH v5 4/5] " Pradeep A. Dalvi
2012-02-06 17:07 ` David Miller
2012-02-06 17:43 ` Pradeep A. Dalvi
2012-02-06 21:16 ` [PATCH v6 " Pradeep A Dalvi
2012-02-08 23:50 ` David Miller
2012-02-05 12:51 ` [PATCH v5 5/5] " Pradeep A. Dalvi
2012-02-06 21:16 ` [PATCH v6 " Pradeep A Dalvi
2012-02-08 23:50 ` David Miller
2012-02-06 16:45 ` [PATCH v5 1/5] " David Miller
2012-02-06 17:37 ` Pradeep A. Dalvi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdXFz5zEWUkrJjNvOqkgt-n2uKc3wzD9H5NKKz1LT4BpOw@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@pradeepdalvi.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).