From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Denis Pauk <pauk.denis@gmail.com>
Cc: ahmad@khalifa.ws, chunkeey@gmail.com, greg@krypto.org,
hubert.banas@gmail.com, igor@svelig.com, jaap.dehaan@freenet.de,
jdelvare@suse.com, jeroen@beerstra.org, jonfarr87@gmail.com,
jwp@redhat.com, kdudka@redhat.com, kernel@melin.net,
kpietrzak@disroot.org, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org, linux@roeck-us.net, me@rebtoor.com,
metalcaedes@gmail.com, michael@theoddone.net,
mikhail.v.gavrilov@gmail.com, mundanedefoliation@gmail.com,
nephartyz@gmail.com, oleksandr@natalenko.name, pehlm@pekholm.org,
renedis@hotmail.com, robert@swiecki.net,
sahan.h.fernando@gmail.com, sebastian.arnhold@posteo.de,
sst@poczta.fm, to.eivind@gmail.com, torvic9@mailbox.org,
linux-riscv <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v4 1/2] hwmon: (nct6775) Directly call ASUS ACPI WMI method
Date: Tue, 6 Jun 2023 12:29:59 +0200 [thread overview]
Message-ID: <CAMuHMdXGO17cKKvwA5sZQ+WBPzdMvghZkvv1gWvQ00X-N+EF9A@mail.gmail.com> (raw)
In-Reply-To: <20230111212241.7456-1-pauk.denis@gmail.com>
Hi Denis,
On Wed, Jan 11, 2023 at 10:24 PM Denis Pauk <pauk.denis@gmail.com> wrote:
> New ASUS B650/B660/X670 boards firmware have not exposed WMI monitoring
> GUID and entrypoint method WMBD could be implemented for different device
> UID.
>
> Implement the direct call to entrypoint method for monitoring the device
> UID of B550/X570 boards.
>
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=204807
> Signed-off-by: Denis Pauk <pauk.denis@gmail.com>
> Co-developed-by: Ahmad Khalifa <ahmad@khalifa.ws>
> Signed-off-by: Ahmad Khalifa <ahmad@khalifa.ws>
Thanks for your patch, which is now commit c3b3747d02f571da ("hwmon:
(nct6775) Directly call ASUS ACPI WMI method") in v6.3-rc1.
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -1516,7 +1516,7 @@ config SENSORS_NCT6775_CORE
> config SENSORS_NCT6775
> tristate "Platform driver for Nuvoton NCT6775F and compatibles"
> depends on !PPC
> - depends on ACPI_WMI || ACPI_WMI=n
> + depends on ACPI || ACPI=n
> select HWMON_VID
> select SENSORS_NCT6775_CORE
> help
The recent patches to add support for ACPI on RISC-V caused me to
see a question about this driver again when running "make oldconfig",
and I had a closer look at the driver...
Unless I am missing something, this is a really dangerous driver which
just bangs blindly into I/O space without doing any platform checks,
which could cause a crash or system lock-up?
Does the SENSORS_NCT6775 symbol need a better platform dependenc
than !PPC?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2023-06-06 10:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 21:22 [PATCH v4 1/2] hwmon: (nct6775) Directly call ASUS ACPI WMI method Denis Pauk
2023-01-11 21:22 ` [PATCH v4 2/2] hwmon: (nct6775) B650/B660/X670 ASUS boards support Denis Pauk
[not found] ` <20230115161224.GA1246527@roeck-us.net>
2023-01-20 19:50 ` Sebastian Arnhold
2023-01-20 20:28 ` Guenter Roeck
2023-01-20 20:32 ` Sebastian Arnhold
2023-06-06 10:29 ` Geert Uytterhoeven [this message]
2023-06-06 13:51 ` [PATCH v4 1/2] hwmon: (nct6775) Directly call ASUS ACPI WMI method Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdXGO17cKKvwA5sZQ+WBPzdMvghZkvv1gWvQ00X-N+EF9A@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=ahmad@khalifa.ws \
--cc=chunkeey@gmail.com \
--cc=greg@krypto.org \
--cc=hubert.banas@gmail.com \
--cc=igor@svelig.com \
--cc=jaap.dehaan@freenet.de \
--cc=jdelvare@suse.com \
--cc=jeroen@beerstra.org \
--cc=jonfarr87@gmail.com \
--cc=jwp@redhat.com \
--cc=kdudka@redhat.com \
--cc=kernel@melin.net \
--cc=kpietrzak@disroot.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=me@rebtoor.com \
--cc=metalcaedes@gmail.com \
--cc=michael@theoddone.net \
--cc=mikhail.v.gavrilov@gmail.com \
--cc=mundanedefoliation@gmail.com \
--cc=nephartyz@gmail.com \
--cc=oleksandr@natalenko.name \
--cc=pauk.denis@gmail.com \
--cc=pehlm@pekholm.org \
--cc=renedis@hotmail.com \
--cc=robert@swiecki.net \
--cc=sahan.h.fernando@gmail.com \
--cc=sebastian.arnhold@posteo.de \
--cc=sst@poczta.fm \
--cc=to.eivind@gmail.com \
--cc=torvic9@mailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).